Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1454333002: Revert of [Cronet] Add QUIC experimental params (Closed)

Created:
5 years, 1 month ago by Derek Bruening
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pauljensen
Base URL:
https://chromium.googlesource.com/chromium/src.git@experiment_ops
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Add QUIC experimental params (patchset #7 id:140001 of https://codereview.chromium.org/1448583003/ ) Reason for revert: [MemSheriff] Reverting CL that contains uninitialized reads that show up in multiple tests on MSan and Valgrind MFYI bots, e.g.: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/11562/steps/browser_tests/logs/ExtensionPreferenceApiTest.DataReductionProxy Original issue's description: > [Cronet] Add QUIC experimental params > > This CL plumbs four QUIC experimental params ( > quic_store_server_configs_in_properties, > quic_delay_tcp_race, > quic_max_number_of_lossy_connections, > quic_packet_loss_threshold) from Cronet's > setExperimentalOptions API to net::HttpNetworkSession. > > This CL also adds a unittests target to run the unittests. > A followup CL will enable the unittests on the cronet bots. > > BUG=545118 > > Committed: https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c > Cr-Commit-Position: refs/heads/master@{#360454} TBR=rtenneti@google.com,rtenneti@chromium.org,mef@chromium.org,xunjieli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=545118 Committed: https://crrev.com/d15ad369c19ff184a0cc633bf133a18440d6c13a Cr-Commit-Position: refs/heads/master@{#360509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -178 lines) Patch
M components/components_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M components/cronet.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +2 lines, -6 lines 0 comments Download
D components/cronet/run_all_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 3 chunks +0 lines, -33 lines 0 comments Download
D components/cronet/url_request_context_config_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +0 lines, -25 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Bruening
Created Revert of [Cronet] Add QUIC experimental params
5 years, 1 month ago (2015-11-19 03:08:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454333002/1
5 years, 1 month ago (2015-11-19 03:08:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 03:10:10 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:10:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d15ad369c19ff184a0cc633bf133a18440d6c13a
Cr-Commit-Position: refs/heads/master@{#360509}

Powered by Google App Engine
This is Rietveld 408576698