Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1454303002: Don't flag third_party/boringssl as needing README.chromium changes. (Closed)

Created:
5 years, 1 month ago by davidben
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't flag third_party/boringssl as needing README.chromium changes. Unlike most things in third_party and like Blink, BoringSSL is unversioned and maintained by us. It is rolled via DEPS in third_party/boringssl/src, but still has Chromium-specific build files checked into the third_party/boringssl directory. Shush presubmit complaining on DEPS rolls when those files change. The one time we might wish to update README.chromium is if something about the license changes, but that would be signaled via a DEPS change and not picked up by this PRESUBMIT rule anyway. BUG=none Committed: https://crrev.com/88ace3fa74d1fff50376eb20a3495798758c4eeb Cr-Commit-Position: refs/heads/master@{#360609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/PRESUBMIT.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
I'm not sure if this qualifies as an exemption here or not, so I'll defer ...
5 years, 1 month ago (2015-11-19 00:46:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-19 09:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454303002/1
5 years, 1 month ago (2015-11-19 16:58:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 17:09:57 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:10:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ace3fa74d1fff50376eb20a3495798758c4eeb
Cr-Commit-Position: refs/heads/master@{#360609}

Powered by Google App Engine
This is Rietveld 408576698