Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454273002: Add test for crash with js-interop @anonymous feature (Closed)

Created:
5 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
5 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for crash with js-interop @anonymous feature R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/081b16141ba9d9465b1163fd67980cda6a648c64

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/interop_anonymous_unreachable_test.dart View 1 chunk +14 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
5 years, 1 month ago (2015-11-18 23:42:20 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1454273002/diff/20001/tests/compiler/dart2js_extra/interop_anonymous_unreachable_test.dart File tests/compiler/dart2js_extra/interop_anonymous_unreachable_test.dart (right): https://codereview.chromium.org/1454273002/diff/20001/tests/compiler/dart2js_extra/interop_anonymous_unreachable_test.dart#newcode11 tests/compiler/dart2js_extra/interop_anonymous_unreachable_test.dart:11: external factory A({bool value}); technically you don't even need ...
5 years, 1 month ago (2015-11-18 23:44:58 UTC) #4
sra1
lgtm
5 years, 1 month ago (2015-11-19 00:06:43 UTC) #5
Siggi Cherem (dart-lang)
5 years, 1 month ago (2015-11-19 00:49:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
081b16141ba9d9465b1163fd67980cda6a648c64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698