@mtomasz: Could you take a look? These image files are separated from the original new-audio-player ...
6 years, 11 months ago
(2014-01-23 06:19:40 UTC)
#1
@mtomasz: Could you take a look? These image files are separated from the
original new-audio-player patch [1]. I'll commit it a minute before the original
patch is committed.
[1] https://codereview.chromium.org/144883002/
mtomasz
On 2014/01/23 06:19:40, yoshiki wrote: > @mtomasz: Could you take a look? These image files ...
6 years, 11 months ago
(2014-01-24 06:58:02 UTC)
#2
On 2014/01/23 06:19:40, yoshiki wrote:
> @mtomasz: Could you take a look? These image files are separated from the
> original new-audio-player patch [1]. I'll commit it a minute before the
original
> patch is committed.
>
> [1] https://codereview.chromium.org/144883002/
lgtm for binaries, but one file is missing:
chrome/browser/resources/file_manager/audio_player/icons/audio-player-96.png
yoshiki
On 2014/01/24 06:58:02, mtomasz wrote: > On 2014/01/23 06:19:40, yoshiki wrote: > > @mtomasz: Could ...
6 years, 11 months ago
(2014-01-28 08:35:33 UTC)
#3
On 2014/01/24 06:58:02, mtomasz wrote:
> On 2014/01/23 06:19:40, yoshiki wrote:
> > @mtomasz: Could you take a look? These image files are separated from the
> > original new-audio-player patch [1]. I'll commit it a minute before the
> original
> > patch is committed.
> >
> > [1] https://codereview.chromium.org/144883002/
>
> lgtm for binaries, but one file is missing:
> chrome/browser/resources/file_manager/audio_player/icons/audio-player-96.png
Thanks! Re-uplaoded.
mtomasz
On 2014/01/28 08:35:33, yoshiki wrote: > On 2014/01/24 06:58:02, mtomasz wrote: > > On 2014/01/23 ...
6 years, 11 months ago
(2014-01-28 08:36:44 UTC)
#4
On 2014/01/28 08:35:33, yoshiki wrote:
> On 2014/01/24 06:58:02, mtomasz wrote:
> > On 2014/01/23 06:19:40, yoshiki wrote:
> > > @mtomasz: Could you take a look? These image files are separated from the
> > > original new-audio-player patch [1]. I'll commit it a minute before the
> > original
> > > patch is committed.
> > >
> > > [1] https://codereview.chromium.org/144883002/
> >
> > lgtm for binaries, but one file is missing:
> > chrome/browser/resources/file_manager/audio_player/icons/audio-player-96.png
>
> Thanks! Re-uplaoded.
lgtm!
yoshiki
I'll dcommit this patch after tree opens.
6 years, 11 months ago
(2014-01-28 08:43:37 UTC)
#5
I'll dcommit this patch after tree opens.
yoshiki
Committed patchset #3 manually as r247591 (presubmit successful).
6 years, 10 months ago
(2014-01-29 02:20:06 UTC)
#6
Message was sent while issue was closed.
Committed patchset #3 manually as r247591 (presubmit successful).
Issue 145423004: [Files.app] Add images of new audio player
(Closed)
Created 6 years, 11 months ago by yoshiki
Modified 6 years, 10 months ago
Reviewers: mtomasz
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0