Add an --enable-deferred-filters command-line flag.

Add an --enable-deferred-filters command-line flag.

This flag causes SVG-on-SVG filters to be drawn with an all-Skia path.
For impl-side painting, this also means that filters will be captured in
the same SkPicture as the rest of the web content. 

BUG=237641
[Today's excellent patch formatting brought to you by jamesr, and the 
letters O, C and D.]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246583

[Stephen White, 2014-01-23 01:13:04]

PTAL. Thanks!

[piman, 2014-01-23 01:19:53]

lgtm

https://codereview.chromium.org/145423002/diff/1/.gitmodules
File .gitmodules (right):

https://codereview.chromium.org/145423002/diff/1/.gitmodules#newcode12
.gitmodules:12: os = all
You probably didn't mean to change this file.

https://codereview.chromium.org/145423002/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/145423002/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:357: const char
kEnableDeferredFilters[]         = "enable-deferred-filters";
nit: Can you add this to kForwardSwitches in
chrome/browser/chromeos/login/chrome_restart_request.cc so that it also applies
to chrome os guest mode?

[Stephen White, 2014-01-23 01:59:51]

On 2014/01/23 01:19:53, piman wrote:
> lgtm
> 
> https://codereview.chromium.org/145423002/diff/1/.gitmodules
> File .gitmodules (right):
> 
> https://codereview.chromium.org/145423002/diff/1/.gitmodules#newcode12
> .gitmodules:12: os = all
> You probably didn't mean to change this file.

Weird.. doesn't show up in local diffs. git cl is having a moment, I guess.

>
https://codereview.chromium.org/145423002/diff/1/content/public/common/conten...
> File content/public/common/content_switches.cc (right):
> 
>
https://codereview.chromium.org/145423002/diff/1/content/public/common/conten...
> content/public/common/content_switches.cc:357: const char
> kEnableDeferredFilters[]         = "enable-deferred-filters";
> nit: Can you add this to kForwardSwitches in
> chrome/browser/chromeos/login/chrome_restart_request.cc so that it also
applies
> to chrome os guest mode?

Done.

[commit-bot: I haz the power, 2014-01-23 02:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/145423002/100001

[commit-bot: I haz the power, 2014-01-23 02:35:06]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Stephen White, 2014-01-23 02:47:17]

+jamesr for webkit/OWNERS

[jamesr, 2014-01-23 02:51:26]

Please reformat the description so the first line fits in 72 columns.  This
patch description will be unreadable for folks looking through the log.

code lgtm

[commit-bot: I haz the power, 2014-01-23 03:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/145423002/100001

[jamesr, 2014-01-23 03:02:44]

Better format is:

First line (describes patch, no longer than 72 col)
(blank line)
Long-form description of the patch that lasts for several lines and is wrapped
at 72 or 80 col.
(blank line)
BUG=....

This just linebreaks at a random point so folks looking at just the first line
of the log for every commit will just see a partially completed thought

[commit-bot: I haz the power, 2014-01-23 09:55:57]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-23 13:02:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/145423002/100001

[commit-bot: I haz the power, 2014-01-23 13:17:52]

Change committed as 246583