Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1454163005: Change float-->double in CanvasRenderingContext2D.idl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
index 17059a8eece1cd63d32529a1662d0e29c43d5e3f..8713551c53b954f4fbf8d22f64755f1c6052dc58 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
@@ -187,7 +187,7 @@ DEFINE_TRACE(CanvasRenderingContext2DState)
CSSFontSelectorClient::trace(visitor);
}
-void CanvasRenderingContext2DState::setLineDashOffset(float offset)
+void CanvasRenderingContext2DState::setLineDashOffset(double offset)
{
m_lineDashOffset = offset;
m_lineDashDirty = true;
@@ -301,7 +301,7 @@ bool CanvasRenderingContext2DState::shouldAntialias() const
return m_fillPaint.isAntiAlias();
}
-void CanvasRenderingContext2DState::setGlobalAlpha(float alpha)
+void CanvasRenderingContext2DState::setGlobalAlpha(double alpha)
{
m_globalAlpha = alpha;
m_strokeStyleDirty = true;
@@ -368,7 +368,7 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution
// StrokePaint respectively for filters that reference SVG.
StyleBuilder::applyProperty(CSSPropertyWebkitFilter, resolverState, m_filterValue.get());
RefPtrWillBeRawPtr<FilterEffectBuilder> filterEffectBuilder = FilterEffectBuilder::create();
- const float effectiveZoom = 1.0f; // Deliberately ignore zoom on the canvas element
+ const double effectiveZoom = 1.0; // Deliberately ignore zoom on the canvas element
filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom);
SkiaImageFilterBuilder imageFilterBuilder;
@@ -412,7 +412,7 @@ SkDrawLooper* CanvasRenderingContext2DState::shadowAndForegroundDrawLooper() con
SkImageFilter* CanvasRenderingContext2DState::shadowOnlyImageFilter() const
{
if (!m_shadowOnlyImageFilter) {
- float sigma = skBlurRadiusToSigma(m_shadowBlur);
+ double sigma = skBlurRadiusToSigma(m_shadowBlur);
m_shadowOnlyImageFilter = adoptRef(SkDropShadowImageFilter::Create(m_shadowOffset.width(), m_shadowOffset.height(), sigma, sigma, m_shadowColor, SkDropShadowImageFilter::kDrawShadowOnly_ShadowMode));
}
return m_shadowOnlyImageFilter.get();
@@ -421,7 +421,7 @@ SkImageFilter* CanvasRenderingContext2DState::shadowOnlyImageFilter() const
SkImageFilter* CanvasRenderingContext2DState::shadowAndForegroundImageFilter() const
{
if (!m_shadowAndForegroundImageFilter) {
- float sigma = skBlurRadiusToSigma(m_shadowBlur);
+ double sigma = skBlurRadiusToSigma(m_shadowBlur);
m_shadowAndForegroundImageFilter = adoptRef(SkDropShadowImageFilter::Create(m_shadowOffset.width(), m_shadowOffset.height(), sigma, sigma, m_shadowColor, SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode));
}
return m_shadowAndForegroundImageFilter.get();
@@ -435,19 +435,19 @@ void CanvasRenderingContext2DState::shadowParameterChanged()
m_shadowAndForegroundImageFilter.clear();
}
-void CanvasRenderingContext2DState::setShadowOffsetX(float x)
+void CanvasRenderingContext2DState::setShadowOffsetX(double x)
{
m_shadowOffset.setWidth(x);
shadowParameterChanged();
}
-void CanvasRenderingContext2DState::setShadowOffsetY(float y)
+void CanvasRenderingContext2DState::setShadowOffsetY(double y)
{
m_shadowOffset.setHeight(y);
shadowParameterChanged();
}
-void CanvasRenderingContext2DState::setShadowBlur(float shadowBlur)
+void CanvasRenderingContext2DState::setShadowBlur(double shadowBlur)
{
m_shadowBlur = shadowBlur;
shadowParameterChanged();

Powered by Google App Engine
This is Rietveld 408576698