Change float-->double in CanvasRenderingContext2D.idl

Change float-->double in CanvasRenderingContext2D.idl

The type should be double according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257, 559182
Committed: https://crrev.com/53bf8ec683c0da3312e6dec83eccf2d057844ed4
Cr-Commit-Position: refs/heads/master@{#360869}

[xidachen, 2015-11-19 18:52:57]

Description was changed from

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be float according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257
==========

to

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be float according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257
==========

[xidachen, 2015-11-19 18:52:57]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2015-11-19 18:55:32]

Hi Justin, 

Please review this CL. Thank you.

https://codereview.chromium.org/1454163005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
(left):

https://codereview.chromium.org/1454163005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h:103: 
These two lines are left out on purpose. The reason is that on line 224 of
CanvasRenderingContext2DState.cpp, it calls "SkDashPathEffect::Create" which
takes an argument of SkScalar*, which is float type. If I change it to
Vector<double>, it will complain there.

[xidachen, 2015-11-19 18:57:19]

Description was changed from

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be float according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257
==========

to

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be double according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257
==========

[Justin Novosad, 2015-11-19 19:23:56]

On 2015/11/19 18:55:32, xidachen wrote:
> Hi Justin, 
>
>
https://codereview.chromium.org/1454163005/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h:103: 
> These two lines are left out on purpose. The reason is that on line 224 of
> CanvasRenderingContext2DState.cpp, it calls "SkDashPathEffect::Create" which
> takes an argument of SkScalar*, which is float type. If I change it to
> Vector<double>, it will complain there.

We can expose it as double in the API and just copy it to a temporary float
array for the call to SkDashPathEffect::Create  That should be simple enough.

[xidachen, 2015-11-20 16:14:20]

Description was changed from

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be double according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257
==========

to

==========
Change float-->double in CanvasRenderingContext2D.idl

The type should be double according to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d
Providing that this change doesn't cause performance regression.

BUG=556257, 559182
==========

[xidachen, 2015-11-20 17:43:27]

Hi Justin,
The CL should be good now, all layout tests passed. There is a mojo_test failed
under linux but I don't think that is related to this change.
Please have a look. Thank you.

[Justin Novosad, 2015-11-20 17:48:14]

lgtm

[xidachen, 2015-11-20 17:54:04]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2015-11-20 17:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454163005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454163005/80001

[commit-bot: I haz the power, 2015-11-20 19:08:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-20 19:09:50]

Patchset 5 (id:??) landed as
https://crrev.com/53bf8ec683c0da3312e6dec83eccf2d057844ed4
Cr-Commit-Position: refs/heads/master@{#360869}