Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc

Issue 1454153002: Revert of This CL replaces e-mail with AccountId on user selection screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/test/ash_test_base.h" 5 #include "ash/test/ash_test_base.h"
6 #include "base/compiler_specific.h" 6 #include "base/compiler_specific.h"
7 #include "chrome/browser/chromeos/login/screens/user_selection_screen.h" 7 #include "chrome/browser/chromeos/login/screens/user_selection_screen.h"
8 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h" 8 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
9 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller.h" 9 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller.h"
10 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller_dele gate.h" 10 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller_dele gate.h"
11 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" 11 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
12 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h" 12 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
13 #include "chrome/test/base/testing_browser_process.h" 13 #include "chrome/test/base/testing_browser_process.h"
14 #include "chrome/test/base/testing_profile_manager.h" 14 #include "chrome/test/base/testing_profile_manager.h"
15 #include "components/proximity_auth/screenlock_bridge.h" 15 #include "components/proximity_auth/screenlock_bridge.h"
16 #include "components/signin/core/account_id/account_id.h"
17 #include "components/user_manager/user.h" 16 #include "components/user_manager/user.h"
18 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
19 18
20 namespace { 19 namespace {
21 20
22 const size_t kMaxUsers = 18; // same as in user_selection_screen.cc 21 const size_t kMaxUsers = 18; // same as in user_selection_screen.cc
23 const char* kOwner = "owner@gmail.com"; 22 const char* kOwner = "owner@gmail.com";
24 const char* kUsersPublic[] = {"public0@gmail.com", "public1@gmail.com"}; 23 const char* kUsersPublic[] = {"public0@gmail.com", "public1@gmail.com"};
25 const char* kUsers[] = { 24 const char* kUsers[] = {
26 "a0@gmail.com", "a1@gmail.com", "a2@gmail.com", "a3@gmail.com", 25 "a0@gmail.com", "a1@gmail.com", "a2@gmail.com", "a3@gmail.com",
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 user_auth_type_map; 79 user_auth_type_map;
81 scoped_ptr<MultiProfileUserController> controller_; 80 scoped_ptr<MultiProfileUserController> controller_;
82 81
83 DISALLOW_COPY_AND_ASSIGN(SigninPrepareUserListTest); 82 DISALLOW_COPY_AND_ASSIGN(SigninPrepareUserListTest);
84 }; 83 };
85 84
86 TEST_F(SigninPrepareUserListTest, AlwaysKeepOwnerInList) { 85 TEST_F(SigninPrepareUserListTest, AlwaysKeepOwnerInList) {
87 EXPECT_LT(kMaxUsers, fake_user_manager_->GetUsers().size()); 86 EXPECT_LT(kMaxUsers, fake_user_manager_->GetUsers().size());
88 user_manager::UserList users_to_send = 87 user_manager::UserList users_to_send =
89 UserSelectionScreen::PrepareUserListForSending( 88 UserSelectionScreen::PrepareUserListForSending(
90 fake_user_manager_->GetUsers(), AccountId::FromUserEmail(kOwner), 89 fake_user_manager_->GetUsers(), kOwner, true /* is signin to add */);
91 true /* is signin to add */);
92 90
93 EXPECT_EQ(kMaxUsers, users_to_send.size()); 91 EXPECT_EQ(kMaxUsers, users_to_send.size());
94 EXPECT_EQ(kOwner, users_to_send.back()->email()); 92 EXPECT_EQ(kOwner, users_to_send.back()->email());
95 93
96 fake_user_manager_->RemoveUserFromList( 94 fake_user_manager_->RemoveUserFromList(
97 AccountId::FromUserEmail("a16@gmail.com")); 95 AccountId::FromUserEmail("a16@gmail.com"));
98 fake_user_manager_->RemoveUserFromList( 96 fake_user_manager_->RemoveUserFromList(
99 AccountId::FromUserEmail("a17@gmail.com")); 97 AccountId::FromUserEmail("a17@gmail.com"));
100 users_to_send = UserSelectionScreen::PrepareUserListForSending( 98 users_to_send = UserSelectionScreen::PrepareUserListForSending(
101 fake_user_manager_->GetUsers(), AccountId::FromUserEmail(kOwner), 99 fake_user_manager_->GetUsers(),
100 kOwner,
102 true /* is signin to add */); 101 true /* is signin to add */);
103 102
104 EXPECT_EQ(kMaxUsers, users_to_send.size()); 103 EXPECT_EQ(kMaxUsers, users_to_send.size());
105 EXPECT_EQ("a18@gmail.com", users_to_send.back()->email()); 104 EXPECT_EQ("a18@gmail.com", users_to_send.back()->email());
106 EXPECT_EQ(kOwner, users_to_send[kMaxUsers-2]->email()); 105 EXPECT_EQ(kOwner, users_to_send[kMaxUsers-2]->email());
107 } 106 }
108 107
109 TEST_F(SigninPrepareUserListTest, PublicAccounts) { 108 TEST_F(SigninPrepareUserListTest, PublicAccounts) {
110 user_manager::UserList users_to_send = 109 user_manager::UserList users_to_send =
111 UserSelectionScreen::PrepareUserListForSending( 110 UserSelectionScreen::PrepareUserListForSending(
112 fake_user_manager_->GetUsers(), AccountId::FromUserEmail(kOwner), 111 fake_user_manager_->GetUsers(), kOwner, true /* is signin to add */);
113 true /* is signin to add */);
114 112
115 EXPECT_EQ(kMaxUsers, users_to_send.size()); 113 EXPECT_EQ(kMaxUsers, users_to_send.size());
116 EXPECT_EQ("a0@gmail.com", users_to_send.front()->email()); 114 EXPECT_EQ("a0@gmail.com", users_to_send.front()->email());
117 115
118 users_to_send = UserSelectionScreen::PrepareUserListForSending( 116 users_to_send = UserSelectionScreen::PrepareUserListForSending(
119 fake_user_manager_->GetUsers(), AccountId::FromUserEmail(kOwner), 117 fake_user_manager_->GetUsers(),
118 kOwner,
120 false /* is signin to add */); 119 false /* is signin to add */);
121 120
122 EXPECT_EQ(kMaxUsers, users_to_send.size()); 121 EXPECT_EQ(kMaxUsers, users_to_send.size());
123 EXPECT_EQ("public0@gmail.com", users_to_send.front()->email()); 122 EXPECT_EQ("public0@gmail.com", users_to_send.front()->email());
124 } 123 }
125 124
126 } // namespace chromeos 125 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698