Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454143005: Update test status files. Issue #24990. (Closed)

Created:
5 years, 1 month ago by turnidge
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M tests/co19/co19-dartium.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 1 month ago (2015-11-19 20:31:17 UTC) #2
siva
lgtm https://codereview.chromium.org/1454143005/diff/20001/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://codereview.chromium.org/1454143005/diff/20001/tests/isolate/isolate.status#newcode90 tests/isolate/isolate.status:90: [ $compiler == none && ($runtime == dartium ...
5 years, 1 month ago (2015-11-19 20:39:16 UTC) #3
turnidge
Committed patchset #3 (id:40001) manually as 05bf1d6bb67c081057c46cdb315ca8977059389a (presubmit successful).
5 years, 1 month ago (2015-11-19 20:43:05 UTC) #4
turnidge
5 years, 1 month ago (2015-11-19 20:43:09 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1454143005/diff/20001/tests/isolate/isolate.s...
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/1454143005/diff/20001/tests/isolate/isolate.s...
tests/isolate/isolate.status:90: [ $compiler == none && ($runtime == dartium ||
$runtime == drt || $runtime == ContentShellOnAndroid) ]
On 2015/11/19 20:39:16, siva wrote:
> why not just club these with the pause_test above.

Done.

Powered by Google App Engine
This is Rietveld 408576698