Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1454113004: resource_bundle_mac_unittest.mm: fix case for AppKit/AppKit.h (Closed)

Created:
5 years, 1 month ago by ukai
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

resource_bundle_mac_unittest.mm: fix case for AppKit/AppKit.h in SDK, it is AppKit.framework/Versions/C/Headers/AppKit.h. Use the same case, so it would work on case sensitive filesystem. BUG= Committed: https://crrev.com/3660c14ebc9a989b2579e5caeab3f64ff04ef717 Cr-Commit-Position: refs/heads/master@{#361259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/resource/resource_bundle_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
ukai
5 years, 1 month ago (2015-11-19 08:25:55 UTC) #3
shrike
On 2015/11/19 08:25:55, ukai wrote: LGTM (sorry about the typeo). I think you will need ...
5 years, 1 month ago (2015-11-19 18:02:47 UTC) #4
ukai
5 years, 1 month ago (2015-11-20 01:29:28 UTC) #6
ukai
ping for owner review.
5 years ago (2015-11-24 01:54:01 UTC) #8
Avi (use Gerrit)
lgtm Yep!
5 years ago (2015-11-24 02:59:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454113004/1
5 years ago (2015-11-24 04:46:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 05:26:58 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 05:28:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3660c14ebc9a989b2579e5caeab3f64ff04ef717
Cr-Commit-Position: refs/heads/master@{#361259}

Powered by Google App Engine
This is Rietveld 408576698