Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: pkg/unittest/lib/html_enhanced_config.dart

Issue 145403005: pkg/unittest: formatter spin (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/lib/html_config.dart ('k') | pkg/unittest/lib/interactive_html_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_enhanced_config.dart
diff --git a/pkg/unittest/lib/html_enhanced_config.dart b/pkg/unittest/lib/html_enhanced_config.dart
index 92759a85777e46465c0ea1fd6bcdfee62f88df9f..f303f244d27cd6a18c8b66b5d81e163d45d271d1 100644
--- a/pkg/unittest/lib/html_enhanced_config.dart
+++ b/pkg/unittest/lib/html_enhanced_config.dart
@@ -68,7 +68,7 @@ class HtmlEnhancedConfiguration extends SimpleConfiguration {
final String _CSSID = '_unittestcss_';
var cssElement = document.head.query('#${_CSSID}');
- if (cssElement == null){
+ if (cssElement == null) {
cssElement = new StyleElement();
cssElement.id = _CSSID;
document.head.append(cssElement);
@@ -148,8 +148,8 @@ class HtmlEnhancedConfiguration extends SimpleConfiguration {
// order by group and sort numerically within each group
var groupedBy = new LinkedHashMap<String, List<TestCase>>();
- for (final t in results){
- if (!groupedBy.containsKey(t.currentGroup)){
+ for (final t in results) {
+ if (!groupedBy.containsKey(t.currentGroup)) {
groupedBy[t.currentGroup] = new List<TestCase>();
}
@@ -174,9 +174,9 @@ class HtmlEnhancedConfiguration extends SimpleConfiguration {
// replace everything but numbers and letters from the group name with
// '_' so we can use in id and class properties.
- var safeGroup = test_.currentGroup.replaceAll(nonAlphanumeric,'_');
+ var safeGroup = test_.currentGroup.replaceAll(nonAlphanumeric, '_');
- if (test_.currentGroup != previousGroup){
+ if (test_.currentGroup != previousGroup) {
previousGroup = test_.currentGroup;
@@ -208,8 +208,8 @@ class HtmlEnhancedConfiguration extends SimpleConfiguration {
// 'safeGroup' could be empty
var grp = (safeGroup == '') ? null : te.query('#${safeGroup}');
- if (grp != null){
- grp.onClick.listen((_){
+ if (grp != null) {
+ grp.onClick.listen((_) {
var row = document.query('.unittest-row-${safeGroup}');
if (row.attributes['class'].contains('unittest-row ')){
document.queryAll('.unittest-row-${safeGroup}').forEach(
@@ -255,8 +255,8 @@ class HtmlEnhancedConfiguration extends SimpleConfiguration {
}
if (!test_.isComplete) {
- addRowElement('${test_.id}', 'NO STATUS', 'Test did not complete.');
- return;
+ addRowElement('${test_.id}', 'NO STATUS', 'Test did not complete.');
+ return;
}
addRowElement('${test_.id}', '${test_.result.toUpperCase()}',
« no previous file with comments | « pkg/unittest/lib/html_config.dart ('k') | pkg/unittest/lib/interactive_html_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698