Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145403002: view manager (Closed)

Created:
6 years, 11 months ago by Ben Goodger (Google)
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Skeleton of a View Manager. This CL doesn't add any real View Management nor does it convert any apps to use this API. Mostly this is just getting the target in and doing the event interception to load the Launcher. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247623

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : focus, etc. #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Total comments: 3

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -12 lines) Patch
M mojo/examples/aura_demo/root_window_host_mojo.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 2 3 4 5 6 7 8 9 8 chunks +54 lines, -10 lines 0 comments Download
A mojo/examples/launcher/launcher.mojom View 1 2 3 4 5 6 7 8 9 1 chunk +19 lines, -0 lines 0 comments Download
A + mojo/examples/view_manager/DEPS View 1 2 7 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/examples/view_manager/view_manager.cc View 1 2 3 4 5 6 7 8 9 1 chunk +191 lines, -0 lines 0 comments Download
A mojo/examples/view_manager/view_manager.mojom View 7 1 chunk +28 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 4 5 3 chunks +50 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport.mojom View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_android.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_android.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_mac.mm View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_stub.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_win.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_x11.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
6 years, 10 months ago (2014-01-28 17:26:51 UTC) #1
Ben Goodger (Google)
On 2014/01/28 17:26:51, Ben Goodger (Google) wrote: Actually please don't review this I forgot to ...
6 years, 10 months ago (2014-01-28 17:42:33 UTC) #2
Ben Goodger (Google)
OK this is ready for review.
6 years, 10 months ago (2014-01-29 00:38:21 UTC) #3
sky
LGTM - just add more comments https://codereview.chromium.org/145403002/diff/150001/mojo/examples/launcher/launcher.cc File mojo/examples/launcher/launcher.cc (right): https://codereview.chromium.org/145403002/diff/150001/mojo/examples/launcher/launcher.cc#newcode144 mojo/examples/launcher/launcher.cc:144: class URLReceiver { ...
6 years, 10 months ago (2014-01-29 00:51:59 UTC) #4
Ben Goodger (Google)
6 years, 10 months ago (2014-01-29 05:16:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #11 manually as r247623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698