Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1454003002: Use invalidation sets for :read-only and :read-write. (Closed)

Created:
5 years, 1 month ago by rune
Modified:
5 years, 1 month ago
Reviewers:
tkent, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets for :read-only and :read-write. Gets rid of SubtreeStyleChange which relies on sibling tree recalcs. R=tkent@chromium.org,ericwilligers@chromium.org BUG=557440 Committed: https://crrev.com/30b0f37300f8d671d29d91102ec7f475ed4cf7fe Cr-Commit-Position: refs/heads/master@{#360298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/read-only-write-pseudo.html View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/read-only-write-pseudo-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454003002/1
5 years, 1 month ago (2015-11-18 00:38:32 UTC) #2
rune
ptal
5 years, 1 month ago (2015-11-18 00:53:42 UTC) #3
tkent
lgtm
5 years, 1 month ago (2015-11-18 01:22:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 02:07:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454003002/1
5 years, 1 month ago (2015-11-18 06:42:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 06:47:44 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30b0f37300f8d671d29d91102ec7f475ed4cf7fe Cr-Commit-Position: refs/heads/master@{#360298}
5 years, 1 month ago (2015-11-18 06:48:41 UTC) #10
Eric Willigers
5 years, 1 month ago (2015-11-20 01:33:56 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698