Add RPC and UI for reachable size of an object / all instances of a class.

Add RPC and UI for reachable size of an object / all instances of a class.

BUG=http://dartbug.com/24945
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/75cd019a9cecf30ef428b114cc2e654b2b6ded02

[rmacnak, 2015-11-17 23:26:48]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-11-18 15:00:20]

https://codereview.chromium.org/1453983002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/reachable_size_test.dart (right):

https://codereview.chromium.org/1453983002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/reachable_size_test.dart:45: fieldValue(String
fieldName) async {
Maybe rename:

getIsolateGlobalVariableValue(Isolate isolate, String variable);

and move into test_helper.dart as a utility method.

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1811: NULL,
new IdParameter("targetId", true),

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1817: if (target_id == NULL) {
ASSERT(target_id != NULL);

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1826: PrintSentinel(js, kCollectedSentinel);
Should GetReachableSize for a collected object be collected? Shouldn't it be 0?

[rmacnak, 2015-11-18 18:07:29]

https://codereview.chromium.org/1453983002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/reachable_size_test.dart (right):

https://codereview.chromium.org/1453983002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/reachable_size_test.dart:45: fieldValue(String
fieldName) async {
On 2015/11/18 15:00:20, Cutch wrote:
> Maybe rename:
> 
> getIsolateGlobalVariableValue(Isolate isolate, String variable);
> 
> and move into test_helper.dart as a utility method.

Done.

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1811: NULL,
On 2015/11/18 15:00:20, Cutch wrote:
> new IdParameter("targetId", true),

Done, here and retained_size

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1817: if (target_id == NULL) {
On 2015/11/18 15:00:20, Cutch wrote:
> ASSERT(target_id != NULL);

Done.

https://codereview.chromium.org/1453983002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1826: PrintSentinel(js, kCollectedSentinel);
On 2015/11/18 15:00:20, Cutch wrote:
> Should GetReachableSize for a collected object be collected? Shouldn't it be
0?

Asking any question about an object that got collected should be fail-stop.

[Cutch, 2015-11-20 01:11:23]

lgtm

[rmacnak, 2015-11-20 18:02:21]

Committed patchset #2 (id:20001) manually as
75cd019a9cecf30ef428b114cc2e654b2b6ded02 (presubmit successful).