Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: test/unittests/compiler/node-test-utils.cc

Issue 1453973004: [turbofan] Fix CFI failures in BytecodeGraphBuilder unit test. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_fix-operator1-1
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/node-test-utils.cc
diff --git a/test/unittests/compiler/node-test-utils.cc b/test/unittests/compiler/node-test-utils.cc
index 8f7057d2c6808a9c28825ee9fedccabddff4a1b2..f7c4756cd78bd588584b9fb8bddbae11eacac33e 100644
--- a/test/unittests/compiler/node-test-utils.cc
+++ b/test/unittests/compiler/node-test-utils.cc
@@ -1460,8 +1460,8 @@ class IsJSLoadNamedMatcher final : public NodeMatcher {
bool MatchAndExplain(Node* node, MatchResultListener* listener) const final {
return (NodeMatcher::MatchAndExplain(node, listener) &&
- PrintMatchAndExplain(OpParameter<const NamedAccess>(node).name(),
- "Name", name_matcher_, listener) &&
+ PrintMatchAndExplain(OpParameter<NamedAccess>(node).name(), "Name",
+ name_matcher_, listener) &&
PrintMatchAndExplain(NodeProperties::GetValueInput(node, 0),
"object", object_value_matcher_, listener) &&
PrintMatchAndExplain(NodeProperties::GetValueInput(node, 1),
@@ -1513,11 +1513,10 @@ class IsJSLoadGlobalMatcher final : public NodeMatcher {
bool MatchAndExplain(Node* node, MatchResultListener* listener) const final {
return (NodeMatcher::MatchAndExplain(node, listener) &&
+ PrintMatchAndExplain(OpParameter<LoadGlobalParameters>(node).name(),
+ "name", name_matcher_, listener) &&
PrintMatchAndExplain(
- OpParameter<const LoadGlobalParameters>(node).name(), "name",
- name_matcher_, listener) &&
- PrintMatchAndExplain(
- OpParameter<const LoadGlobalParameters>(node).typeof_mode(),
+ OpParameter<LoadGlobalParameters>(node).typeof_mode(),
"typeof mode", typeof_mode_matcher_, listener) &&
PrintMatchAndExplain(NodeProperties::GetValueInput(node, 0),
"feedback vector", feedback_vector_matcher_,
@@ -1567,19 +1566,19 @@ class IsJSStoreGlobalMatcher final : public NodeMatcher {
}
bool MatchAndExplain(Node* node, MatchResultListener* listener) const final {
- return (NodeMatcher::MatchAndExplain(node, listener) &&
- PrintMatchAndExplain(
- OpParameter<const StoreGlobalParameters>(node).name(), "name",
- name_matcher_, listener) &&
- PrintMatchAndExplain(NodeProperties::GetValueInput(node, 0),
- "value", value_matcher_, listener) &&
- PrintMatchAndExplain(NodeProperties::GetValueInput(node, 1),
- "feedback vector", feedback_vector_matcher_,
- listener) &&
- PrintMatchAndExplain(NodeProperties::GetEffectInput(node), "effect",
- effect_matcher_, listener) &&
- PrintMatchAndExplain(NodeProperties::GetControlInput(node),
- "control", control_matcher_, listener));
+ return (
+ NodeMatcher::MatchAndExplain(node, listener) &&
+ PrintMatchAndExplain(OpParameter<StoreGlobalParameters>(node).name(),
+ "name", name_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetValueInput(node, 0), "value",
+ value_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetValueInput(node, 1),
+ "feedback vector", feedback_vector_matcher_,
+ listener) &&
+ PrintMatchAndExplain(NodeProperties::GetEffectInput(node), "effect",
+ effect_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetControlInput(node), "control",
+ control_matcher_, listener));
}
private:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698