Issue 145393004: Update components/autofill code to use WebElementCollection instead of WebNodeCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145393004: Update components/autofill code to use WebElementCollection instead of WebNodeCollection (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit), Evan Stade

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update components/autofill code to use WebElementCollection instead of WebNodeCollection Update components/autofill code to use WebElementCollection instead of WebNodeCollection. After Blink r166411 and r166500, WebNodeCollection is renamed to WebElementCollection and its API returns WebElements instead of WebNodes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249732

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	components/autofill/content/renderer/autofill_agent.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	components/autofill/content/renderer/form_autofill_util.cc	View		5 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/145393004/40001

6 years, 10 months ago (2014-02-07 14:34:26 UTC) #4

Message was sent while issue was closed.

Change committed as 249732

Expand Messages | Collapse Messages