Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1453923002:
Make the EarlyInitStartup Code Default (Closed)
|
Created:
5 years, 1 month ago by robliao Modified:
3 years, 6 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews, sky Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the EarlyInitStartup Code Default
We're satisfied with the performance characteristics of running Extension
Feature Initialization on a background thread that we'd like to do it
all the time now.
BUG=470743
Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae
Cr-Commit-Position: refs/heads/master@{#360352}
Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0
Cr-Commit-Position: refs/heads/master@{#378308}
Patch Set 1 #
Messages
Total messages: 49 (20 generated)
robliao@chromium.org changed reviewers: + sky@chromium.org
Is there a reason you don't want to have Jochen review this? He is more familiar with the code as he reviewed the addition of the code.
On 2015/11/17 23:13:53, sky wrote: > Is there a reason you don't want to have Jochen review this? He is more familiar > with the code as he reviewed the addition of the code. You showed up #2 on the suggested reviewers list and you were in the MTV time zone, so I figured you would be a good choice. I can change to jochen if you'd rather do that.
Description was changed from ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 ========== to ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 ==========
robliao@chromium.org changed reviewers: - sky@chromium.org
robliao@chromium.org changed reviewers: + jochen@chromium.org
lgtm
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1467503002/ by robliao@chromium.org. The reason for reverting is: Backing out to see the effect on the perf graphs..
Message was sent while issue was closed.
Description was changed from ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} ========== to ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} ==========
This change is not suspected in affecting the main Windows perf bots (which incidentally did not regress), just a few of the GPU ones. Will recommit if the revert does not make an impact. The perf issue is tracked in https://code.google.com/p/chromium/issues/detail?id=558432
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/02/25 19:28:55, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Given that the perf trybots continue to be down (issue filed http://crbug.com/585525), I'll likely be recommitting this soon for any necessary investigation, especially given that only the GPU bots failed in the past.
On 2016/02/25 22:07:43, robliao wrote: > On 2016/02/25 19:28:55, commit-bot: I haz the power wrote: > > Dry run: This issue passed the CQ dry run. > > Given that the perf trybots continue to be down (issue filed > http://crbug.com/585525), I'll likely be recommitting this soon for any > necessary investigation, especially given that only the GPU bots failed in the > past. Can you add a summary of the Finch results on the bug for reference? Also, don't forget to remove this experiment from the Finch servers after this lands.
On 2016/02/26 14:47:39, gab wrote: > On 2016/02/25 22:07:43, robliao wrote: > > On 2016/02/25 19:28:55, commit-bot: I haz the power wrote: > > > Dry run: This issue passed the CQ dry run. > > > > Given that the perf trybots continue to be down (issue filed > > http://crbug.com/585525), I'll likely be recommitting this soon for any > > necessary investigation, especially given that only the GPU bots failed in the > > past. > > Can you add a summary of the Finch results on the bug for reference? > > Also, don't forget to remove this experiment from the Finch servers after this > lands. Done and will do once we stabilize on this. Thanks!
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/02/26 20:45:28, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) Tree is currently on fire. Will retry a bit later.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453923002/1
Message was sent while issue was closed.
Description was changed from ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} ========== to ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} ========== to ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0 Cr-Commit-Position: refs/heads/master@{#378308} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0 Cr-Commit-Position: refs/heads/master@{#378308}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1749213005/ by robliao@chromium.org. The reason for reverting is: Reverting - Looks like we can't easily get perf data from the bots..
Message was sent while issue was closed.
Description was changed from ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0 Cr-Commit-Position: refs/heads/master@{#378308} ========== to ========== Make the EarlyInitStartup Code Default We're satisfied with the performance characteristics of running Extension Feature Initialization on a background thread that we'd like to do it all the time now. BUG=470743 Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae Cr-Commit-Position: refs/heads/master@{#360352} Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0 Cr-Commit-Position: refs/heads/master@{#378308} ==========
Message was sent while issue was closed.
I'm going to move to this to use the task scheduler. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
