Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: services/keyboard_native/main.cc

Issue 1453823005: Implement Linux IME support (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add service name annotation, remove unused member variables Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/keyboard/linux/main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/keyboard_native/main.cc
diff --git a/services/keyboard_native/main.cc b/services/keyboard_native/main.cc
index 1ad253703162cbf9136d94854abf29bcf804a1c9..b3d9d5ac8e1e6cdda142ed14d5d39b83248feb25 100644
--- a/services/keyboard_native/main.cc
+++ b/services/keyboard_native/main.cc
@@ -17,16 +17,17 @@
namespace keyboard {
-class KeyboardServiceFactory : public mojo::InterfaceFactory<KeyboardService> {
+class NativeKeyboardServiceFactory
+ : public mojo::InterfaceFactory<KeyboardService> {
public:
- explicit KeyboardServiceFactory(
+ explicit NativeKeyboardServiceFactory(
mojo::InterfaceRequest<mojo::ServiceProvider> service_provider_request) {
if (service_provider_request.is_pending()) {
service_provider_impl_.Bind(service_provider_request.Pass());
service_provider_impl_.AddService<KeyboardService>(this);
}
}
- ~KeyboardServiceFactory() override {}
+ ~NativeKeyboardServiceFactory() override {}
void OnViewCreated(mojo::View* view, mojo::Shell* shell) {
view_observer_delegate_.OnViewCreated(view, shell);
@@ -68,8 +69,8 @@ class KeyboardServiceDelegate : public mojo::ApplicationDelegate,
void OnEmbed(mojo::View* root,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
mojo::ServiceProviderPtr exposed_services) override {
- KeyboardServiceFactory* keyboard_service_factory =
- new KeyboardServiceFactory(services.Pass());
+ NativeKeyboardServiceFactory* keyboard_service_factory =
+ new NativeKeyboardServiceFactory(services.Pass());
keyboard_service_factory->OnViewCreated(root, shell_);
}
« no previous file with comments | « services/keyboard/linux/main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698