Implement Linux IME support

services/keyboard/linux/keyboard_service_impl.h

Index: services/keyboard/linux/keyboard_service_impl.h
diff --git a/services/keyboard/linux/keyboard_service_impl.h b/services/keyboard/linux/keyboard_service_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..f3108a9ae5975e8ca7ef034a0208820473c2b34e
--- /dev/null
+++ b/services/keyboard/linux/keyboard_service_impl.h
@@ -0,0 +1,51 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_
+#define SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_
+
+#include "base/macros.h"
+#include "mojo/public/cpp/application/interface_factory.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/interfaces/application/shell.mojom.h"
+#include "mojo/services/keyboard/interfaces/keyboard.mojom.h"
+#include "mojo/services/native_viewport/interfaces/native_viewport.mojom.h"
+
+namespace keyboard {
+
+class LinuxKeyboardServiceImpl : public keyboard::KeyboardService,
+                                 public mojo::NativeViewportEventDispatcher {
+ public:
+  LinuxKeyboardServiceImpl(
+      mojo::InterfaceRequest<keyboard::KeyboardService> request,
+      mojo::InterfaceRequest<NativeViewportEventDispatcher> dispatcher);
+  ~LinuxKeyboardServiceImpl() override;
+
+  // |KeyboardService| overrides:
+  void Show(keyboard::KeyboardClientPtr client,
+            keyboard::KeyboardType type) override;
+  void ShowByRequest() override;
+  void Hide() override;
+  void SetText(const mojo::String& text) override;
+  void SetSelection(int32_t start, int32_t end) override;
+
+  // |NativeViewportEventDispatcher| overrides:
+  void OnEvent(mojo::EventPtr event,
+               const mojo::Callback<void()>& callback) override;

[jamesr, 2015/11/20 00:09:02]

FYI the C++ code generator produces a typedef for the callback type called
'<method name>Callback', so you can say 'const mojo::OnEventCallback& callback'
instead of tying out the function signature

[Kris, 2015/11/20 01:37:35]

Done.

+
+ private:
+  mojo::Shell* shell_;
+  mojo::ApplicationConnection* connection_;

[jamesr, 2015/11/20 00:09:02]

these two members appear unused, delete

[Kris, 2015/11/20 01:37:35]

Done.

+  mojo::StrongBinding<keyboard::KeyboardService> binding_;

[jamesr, 2015/11/20 00:09:02]

i think you should put the StrongBinding<> last in the member list since it
controls the lifetime of the object so you probably want it to be destructed
before other member variables. otherwise, if the object is still live while
destructors for other members run, they could end up calling into the binding_
object and it won't yet know that destruction is under way

[Kris, 2015/11/20 01:37:35]

Done.

+  mojo::Binding<mojo::NativeViewportEventDispatcher> event_dispatcher_binding_;
+
+  keyboard::KeyboardClientPtr client_;
+  std::string text_;
+
+  DISALLOW_COPY_AND_ASSIGN(LinuxKeyboardServiceImpl);
+};
+
+}  // namespace keyboard
+
+#endif /* defined(SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_) */

[jamesr, 2015/11/20 00:09:02]

#endif  // SERVICES_...

we basically never use /* */ style comments in c++ code

[Kris, 2015/11/20 01:37:35]

Done.