Implement Linux IME support

services/keyboard/linux/keyboard_service_impl.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_
+#define SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_
+
+#include "base/macros.h"
+#include "mojo/public/cpp/application/interface_factory.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/interfaces/application/shell.mojom.h"
+#include "mojo/services/keyboard/interfaces/keyboard.mojom.h"
+#include "mojo/services/native_viewport/interfaces/native_viewport.mojom.h"
+
+namespace keyboard {
+
+class LinuxKeyboardServiceImpl : public ::keyboard::KeyboardService,

[jamesr, 2015/11/19 23:47:33]

omit the :: in "::keyboard"

+                                 public mojo::NativeViewportEventDispatcher {
+ public:
+  explicit LinuxKeyboardServiceImpl(

[jamesr, 2015/11/19 23:47:33]

only say 'explicit' if it's a one-argument constructor. implicit conversions are
much more difficult to accidentally trigger for multi-arg constructors

+      mojo::InterfaceRequest<::keyboard::KeyboardService> request,
+      mojo::InterfaceRequest<NativeViewportEventDispatcher> dispatcher);
+  ~LinuxKeyboardServiceImpl() override;
+  void Show(::keyboard::KeyboardClientPtr client,

[jamesr, 2015/11/19 23:47:33]

nit: put a blank line and a comment before these indicating what base class they
are overriding, i.e.
"// keyboard::KeyboardService implementation."

+            ::keyboard::KeyboardType type) override;
+  void ShowByRequest() override;
+  void Hide() override;
+  void SetText(const mojo::String& text) override;
+  void SetSelection(int32_t start, int32_t end) override;
+
+  void OnEvent(mojo::EventPtr event,

[jamesr, 2015/11/19 23:47:33]

ditto here: "// mojo::NativeViewportEventDispatcher implementation."

+               const mojo::Callback<void()>& callback) override;
+
+ private:
+  mojo::Shell* shell_;
+  mojo::ApplicationConnection* connection_;
+  mojo::StrongBinding<::keyboard::KeyboardService> binding_;
+  mojo::Binding<mojo::NativeViewportEventDispatcher> event_dispatcher_binding_;
+
+  ::keyboard::KeyboardClientPtr client_;
+  std::string text_;
+
+  DISALLOW_COPY_AND_ASSIGN(LinuxKeyboardServiceImpl);
+};
+
+}  // namespace keyboard
+
+#endif /* defined(SERVICES_KEYBOARD_LINUX_KEYBOARD_SERVICE_IMPL_H_) */