Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: ui/base/touch/touch_enabled.cc

Issue 1453813003: Fix a regression in checking the status of the touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dtapuska's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/touch/touch_enabled.h ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/touch/touch_enabled.cc
diff --git a/ui/base/touch/touch_enabled.cc b/ui/base/touch/touch_enabled.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6791a2557699be88b3363cfa3e3ae3669ecfb112
--- /dev/null
+++ b/ui/base/touch/touch_enabled.cc
@@ -0,0 +1,51 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/base/touch/touch_enabled.h"
+
+#include "base/command_line.h"
+#include "base/logging.h"
+#include "ui/base/touch/touch_device.h"
+#include "ui/base/ui_base_switches.h"
+#include "ui/events/base_event_utils.h"
+#include "ui/events/event_switches.h"
+
+namespace ui {
+
+namespace {
+
+bool ComputeTouchStatus() {
+ auto* command_line = base::CommandLine::ForCurrentProcess();
+ const std::string touch_enabled_switch =
+ command_line->HasSwitch(switches::kTouchEvents) ?
+ command_line->GetSwitchValueASCII(switches::kTouchEvents) :
+ switches::kTouchEventsAuto;
+
+ if (touch_enabled_switch.empty() ||
+ touch_enabled_switch == switches::kTouchEventsEnabled) {
+ return true;
+ }
+
+ if (touch_enabled_switch == switches::kTouchEventsAuto)
+ return IsTouchDevicePresent();
+
+ DLOG_IF(ERROR, touch_enabled_switch != switches::kTouchEventsDisabled) <<
+ "Invalid --touch-events option: " << touch_enabled_switch;
+ return false;
+}
+
+} // namespace
+
+bool AreTouchEventsEnabled() {
+ static bool touch_status = ComputeTouchStatus();
+
+#if defined(OS_CHROMEOS) && defined(USE_X11)
+ return touch_status && GetTouchEventsCrOsX11MasterSwitch();
sadrul 2015/11/18 20:58:46 On a chromeos device build (i.e. when USE_X11 is n
afakhry 2015/11/18 21:03:13 On non-X11 ChromeOS builds (i.e. Ozone builds) we
sadrul 2015/11/18 21:14:30 The various places that call AreTouchEventsEnabled
afakhry 2015/11/18 21:33:04 Valid point! Thanks. I now set the switch on ozone
+#else
+ return touch_status;
+#endif // !defined(OS_CHROMEOS) && defined(USE_X11)
+}
+
+} // namespace ui
+
« no previous file with comments | « ui/base/touch/touch_enabled.h ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698