Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1453803002: Separate RenderViewHost from RenderWidgetHost, part 10: shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nick's nits Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 6fda5e197cd16aa034611560555384fc608fe4ea..3410c52b67c29c380c7110a06164c3c16904f582 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -60,8 +60,6 @@
#include "content/public/browser/browser_plugin_guest_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/native_web_keyboard_event.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_widget_host_view_frame_subscriber.h"
#import "content/public/browser/render_widget_host_view_mac_delegate.h"
#include "content/public/browser/web_contents.h"
@@ -1058,23 +1056,6 @@ void RenderWidgetHostViewMac::RenderProcessGone(base::TerminationStatus status,
Destroy();
}
-void RenderWidgetHostViewMac::RenderWidgetHostGone() {
- // Clear SurfaceID namespace ownership before we shutdown the
- // compositor.
- if (UseSurfacesEnabled() && render_widget_host_ &&
- render_widget_host_->delegate() &&
- render_widget_host_->delegate()->GetInputEventRouter()) {
- render_widget_host_->delegate()
- ->GetInputEventRouter()
- ->RemoveSurfaceIdNamespaceOwner(GetSurfaceIdNamespace());
- }
-
- // Destroy the DelegatedFrameHost, to prevent crashes when Destroy is never
- // called on the view.
- // http://crbug.com/404828
- ShutdownBrowserCompositor();
-}
-
void RenderWidgetHostViewMac::Destroy() {
[[NSNotificationCenter defaultCenter]
removeObserver:cocoa_view_
@@ -1636,7 +1617,7 @@ bool RenderWidgetHostViewMac::Send(IPC::Message* message) {
void RenderWidgetHostViewMac::ShutdownHost() {
weak_factory_.InvalidateWeakPtrs();
- render_widget_host_->Shutdown();
+ render_widget_host_->ShutdownAndDestroyWidget(true);
// Do not touch any members at this point, |this| has been deleted.
}
@@ -2104,7 +2085,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
renderWidgetHostView_->fullscreen_parent_host_view();
if (parent)
parent->cocoa_view()->suppressNextEscapeKeyUp_ = YES;
- widgetHost->Shutdown();
+ widgetHost->ShutdownAndDestroyWidget(true);
return;
}

Powered by Google App Engine
This is Rietveld 408576698