content/browser/renderer_host/render_widget_host_view_base.h - Issue 1453803002: Separate RenderViewHost from RenderWidgetHost, part 10: shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 1453803002: Separate RenderViewHost from RenderWidgetHost, part 10: shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nick's nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 1f1e43c05f3d537c86af3e250cc4a9220d1c4e42..5831ca71c43756c069f37afedfb563e0278d065b 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -254,13 +254,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

virtual void RenderProcessGone(base::TerminationStatus status,

int error_code) = 0;

- // Notifies the View that the renderer's host has ceased to exist.

- // The default implementation of this is a no-op. This hack exists to fix

- // a crash on the branch.

- // TODO(ccameron): Clean this up.

- // http://crbug.com/404828

- virtual void RenderWidgetHostGone() {}

// Tells the View to destroy itself.

virtual void Destroy() = 0;