content/browser/renderer_host/render_view_host_impl.h - Issue 1453803002: Separate RenderViewHost from RenderWidgetHost, part 10: shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1453803002: Separate RenderViewHost from RenderWidgetHost, part 10: shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no dcheck for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | content/browser/renderer_host/render_widget_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index d966e5eefe71b8ae66ea259b472044379185d103..73fef03fca0bd737dff04060b55259cfcf633e5c 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -105,6 +105,8 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

// Convenience function, just like RenderViewHost::From.

static RenderViewHostImpl* From(RenderWidgetHost* rwh);

+ void ShutdownAndDestroy();

ncarter (slow) 2015/12/11 22:13:29 This belongs after the ctor/dtor.

Avi (use Gerrit) 2015/12/14 02:03:49 Done.

// |routing_id| must be a valid route id. |swapped_out| indicates

// whether the view should initially be swapped out (e.g., for an opener

// frame being rendered by another process). |hidden| indicates whether the

@@ -278,7 +280,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

}

// RenderWidgetHost public overrides.

- void Shutdown() override;

bool OnMessageReceived(const IPC::Message& msg) override;

// Creates a new RenderView with the given route id.