Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1453733002: [turbofan] Fix several OSR entries within literals. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix several OSR entries within literals. With do-expressions any expression used within literals can turn into an OSR entry-point. This means the literal object being constructed is then renamed to an OSR value and needs to be reloaded from the environment. R=rossberg@chromium.org TEST=mjsunit/regress/regress-osr-in-literal Committed: https://crrev.com/132107539181beabe2a2f6087f1901c83cf1411f Cr-Commit-Position: refs/heads/master@{#32050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-osr-in-literal.js View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-17 15:07:10 UTC) #1
Michael Starzinger
Andreas: PTAL. Caitlin: FYI.
5 years, 1 month ago (2015-11-17 15:08:09 UTC) #3
rossberg
lgtm
5 years, 1 month ago (2015-11-17 15:09:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453733002/1
5 years, 1 month ago (2015-11-17 15:23:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 15:24:58 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 15:25:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/132107539181beabe2a2f6087f1901c83cf1411f
Cr-Commit-Position: refs/heads/master@{#32050}

Powered by Google App Engine
This is Rietveld 408576698