Subzero: Improve the "make check-presubmit" target.

Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the presubmit tests can easily be run before committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

4. Document the individual steps.

BUG= none
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=23bee88492b83c132ae18eded1b5143fb501d085

[Jim Stichnoth, 2015-11-17 13:43:02]

Description was changed from

==========
Add "presubmit" as an alias to "check-presubmit".


Subzero: Improve the "make check-presubmit" target.

BUG= none
==========

to

==========
Subzero: Improve the "make check-presubmit" target.

BUG= none
==========

[Jim Stichnoth, 2015-11-17 13:46:03]

Description was changed from

==========
Subzero: Improve the "make check-presubmit" target.

BUG= none
==========

to

==========
Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings
before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the tests can easily be run before
committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

BUG= none
==========

[Jim Stichnoth, 2015-11-17 13:46:38]

Description was changed from

==========
Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings
before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the tests can easily be run before
committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

BUG= none
==========

to

==========
Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings
before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the tests can easily be run before
committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

4. Document the individual steps.

BUG= none
==========

[Jim Stichnoth, 2015-11-17 13:49:39]

Description was changed from

==========
Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings
before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the tests can easily be run before
committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

4. Document the individual steps.

BUG= none
==========

to

==========
Subzero: Improve the "make check-presubmit" target.

1. Include a test build (but no link) using g++, to identify errors and warnings
before they hit the Windows bots.

2. Move "git diff --quiet" to the end so that the presubmit tests can easily be
run before committing locally, if desired.

3. Add "make presubmit" as an alias for "make check-presubmit".

4. Document the individual steps.

BUG= none
==========

[Jim Stichnoth, 2015-11-17 13:49:39]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, sehr@chromium.org

[John, 2015-11-17 14:06:11]

lgtm

https://codereview.chromium.org/1453713002/diff/1/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1453713002/diff/1/Makefile.standalone#newcode434
Makefile.standalone:434: NPROCS := $(shell grep processor /proc/cpuinfo | wc -l)
Do you still need this?

[Jim Stichnoth, 2015-11-17 14:09:24]

https://codereview.chromium.org/1453713002/diff/1/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1453713002/diff/1/Makefile.standalone#newcode434
Makefile.standalone:434: NPROCS := $(shell grep processor /proc/cpuinfo | wc -l)
On 2015/11/17 14:06:11, John wrote:
> Do you still need this?

Good point!  Done.

[Jim Stichnoth, 2015-11-17 14:14:09]

Committed patchset #2 (id:20001) manually as
23bee88492b83c132ae18eded1b5143fb501d085 (presubmit successful).