Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1453653003: [turbofan] Add support for special JSArrayBufferView accessors. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for special JSArrayBufferView accessors. Lower access to byteOffset and byteLength getters on JSArrayBufferViews and to length on JSTypedArrays. This requires a check to see whether the backing JSArrayBuffer was neutered. R=mstarzinger@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/3e328bf254004833f32ba889837ce10889b8ac3a Cr-Commit-Position: refs/heads/master@{#32070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -9 lines) Patch
M src/compiler/access-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/access-info.h View 5 chunks +15 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 5 chunks +32 lines, -8 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-17 15:23:47 UTC) #1
Benedikt Meurer
Hey Michi, Extending the support for "special JSObject in-object properties" to also cover the JSArrayBufferView ...
5 years, 1 month ago (2015-11-17 15:24:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453653003/1
5 years, 1 month ago (2015-11-17 15:56:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 15:59:30 UTC) #6
Jarin
lgtm
5 years, 1 month ago (2015-11-18 06:30:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453653003/1
5 years, 1 month ago (2015-11-18 06:30:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 06:32:40 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 06:33:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e328bf254004833f32ba889837ce10889b8ac3a
Cr-Commit-Position: refs/heads/master@{#32070}

Powered by Google App Engine
This is Rietveld 408576698