Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1453633002: Reland of land: Enable Wallet metadata sync. (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rouslan+autofill_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of land: Enable Wallet metadata sync. (patchset #1 id:1 of https://codereview.chromium.org/1444743002/ ) Reason for revert: Original patch doesn't seem like to be the cause of the regression Original issue's description: > Revert of Reland: Enable Wallet metadata sync. (patchset #1 id:1 of https://codereview.chromium.org/1396883005/ ) > > Reason for revert: > Speculative revert to see if this patch regresses blink_perf.shadow_dom benchmark > > BUG=543496 > > Original issue's description: > > Reland: Enable Wallet metadata sync. > > > > Originally landed in https://crrev.com/90c4e947, which enabled a code > > path where https://crrev.com/6aeb9079 introduced a bug a few hours > > earlier. The bug was detected in tests, which resulted in a revert. > > https://crrev.com/7a8e3fdf fixed the bug in the hidden code path. It's > > safe to reland now. > > > > TBR=zea@chromium.org, estade@chromium.org > > BUG=481595 > > > > Committed: https://crrev.com/0b999094d4ce8a462b70327cc38ca117313a1504 > > Cr-Commit-Position: refs/heads/master@{#353927} > > TBR=estade@chromium.org,zea@chromium.org,rouslan@chromium.org > BUG=481595 > > Committed: https://crrev.com/b70233fbb79edf633ca9826c35923f6612d7b476 > Cr-Commit-Position: refs/heads/master@{#359666} TBR=estade@chromium.org,zea@chromium.org,rouslan@chromium.org BUG=543496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Reland of land: Enable Wallet metadata sync.
5 years, 1 month ago (2015-11-17 02:44:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453633002/1
5 years, 1 month ago (2015-11-17 02:45:35 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 02:48:30 UTC) #6
Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698