Do not reschedule all alarms when adding a new alarm

Do not reschedule all alarms when adding a new alarm
BUG=338900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247823

[Devlin, 2014-01-29 17:01:59]

Yoyo - mind taking a look when you get a chance?

[Yoyo Zhou, 2014-01-29 21:30:15]

https://chromiumcodereview.appspot.com/145353013/diff/40001/chrome/browser/ex...
File chrome/browser/extensions/api/alarms/alarm_manager.cc (right):

https://chromiumcodereview.appspot.com/145353013/diff/40001/chrome/browser/ex...
chrome/browser/extensions/api/alarms/alarm_manager.cc:286:
ScheduleTimer(alarm_time);
This is a shortcut to setting the time (does it still respect minimum
granularity?), but it seems like a simpler change is to just call
ScheduleNextPoll in this if condition.

https://chromiumcodereview.appspot.com/145353013/diff/40001/chrome/browser/ex...
File chrome/browser/extensions/api/alarms/alarm_manager.h (right):

https://chromiumcodereview.appspot.com/145353013/diff/40001/chrome/browser/ex...
chrome/browser/extensions/api/alarms/alarm_manager.h:189: void
ScheduleTimer(const base::Time& time);
Can this be called SetNextPollTime or some such? It's not really a parallel to
ScheduleNextPoll.

[Devlin, 2014-01-29 21:46:16]

https://codereview.chromium.org/145353013/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/alarms/alarm_manager.cc (right):

https://codereview.chromium.org/145353013/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/alarms/alarm_manager.cc:286:
ScheduleTimer(alarm_time);
On 2014/01/29 21:30:16, Yoyo Zhou wrote:
> This is a shortcut to setting the time (does it still respect minimum
> granularity?), but it seems like a simpler change is to just call
> ScheduleNextPoll in this if condition.

Discussed offline - granularity isn't really an issue because this is only done
in AddAlarm, and all granularities will be respected when/if the alarm is
rescheduled.

https://codereview.chromium.org/145353013/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/alarms/alarm_manager.h (right):

https://codereview.chromium.org/145353013/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/alarms/alarm_manager.h:189: void
ScheduleTimer(const base::Time& time);
On 2014/01/29 21:30:16, Yoyo Zhou wrote:
> Can this be called SetNextPollTime or some such? It's not really a parallel to
> ScheduleNextPoll.

Done.

[Yoyo Zhou, 2014-01-29 21:51:49]

LGTM

[commit-bot: I haz the power, 2014-01-29 21:56:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/145353013/...

[commit-bot: I haz the power, 2014-01-30 03:04:21]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 03:11:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/145353013/...

[commit-bot: I haz the power, 2014-01-30 04:01:06]

Change committed as 247823