Gate console.log output in Google Now

chrome/browser/resources/google_now/common_test_util.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Common test utilities.
 
+/**
+ * Allows console.log output.
+ */
+var showConsoleLogOutput = false;

[vadimt, 2014/01/28 21:07:12]

showConsoleLogOutput seems to be a constant set to false.
Probably, if we want unit tests to always show console output, it should be
true? However, if it's a constant that no one changes, do we need it at all?

[robliao, 2014/01/28 21:56:02]

One of the main complaints is that the unit tests are too chatty. The request
here is to turn them off.
On 2014/01/28 21:07:12, vadimt wrote:

+
+/**
+ * Conditionally allow console.log output based off of showConsoleLogOutput.
+ */
+console.log = function() {
+  var originalConsoleLog = console.log;
+  return function() {
+    if (showConsoleLogOutput) {
+      originalConsoleLog.apply(console, arguments);
+    }
+  };
+}();
+
 function emptyMock() {}
 
 // Container for event handlers added by mocked 'addListener' functions.
 var mockEventHandlers = {};
 
 /**
  * Mocks 'addListener' function of an API event. The mocked function will keep
  * track of handlers.
  * @param {Object} topLevelContainer Top-level container of the original
  *     function. Can be either 'chrome' or 'instrumented'.
@@ skipping 30 matching lines @@
  */
 function getMockHandlerContainer(eventIdentifier) {
   var eventIdentifierParts = eventIdentifier.split('.');
   var mockEventContainer = mockEventHandlers;
   eventIdentifierParts.forEach(function(fragment) {
     mockEventContainer = mockEventContainer[fragment];
   });
 
   return mockEventContainer;
 }