src/heap-snapshot-generator.h - Issue 145353003: Allow arbitrary names for weak references in heap snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.h

Issue 145353003: Allow arbitrary names for weak references in heap snapshots. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.h

diff --git a/src/heap-snapshot-generator.h b/src/heap-snapshot-generator.h

index d93362f63bc1a6d61fa90792b660a1e0b9432a2a..c14fbb2108a32fb0559a3a1254bb5add2e188fb1 100644

--- a/src/heap-snapshot-generator.h

+++ b/src/heap-snapshot-generator.h

@@ -448,7 +448,7 @@ class V8HeapExplorer : public HeapEntriesAllocator {

Object* child);

void SetWeakReference(HeapObject* parent_obj,

int parent,

- int index,

+ const char* reference_name,

Object* child_obj,

int field_offset);

void SetPropertyReference(HeapObject* parent_obj,

« no previous file with comments | « no previous file | src/heap-snapshot-generator.cc » ('j') | src/heap-snapshot-generator.cc » ('J')