Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1453513002: Uses a HashMap to complete deferred library loads. (Closed)

Created:
5 years, 1 month ago by zra
Modified:
5 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Uses a HashMap to complete deferred library loads. HashMap.forEach is a few ms faster to compile than LinkedHashMap.forEach, and iteration order appears not to matter for _outstandingLoadRequests. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/871e4a2788cb1ddceac741e815c272a9c45c4680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/lib/lib_prefix.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
5 years, 1 month ago (2015-11-16 22:20:10 UTC) #4
hausner
lgtm
5 years, 1 month ago (2015-11-17 18:35:28 UTC) #5
zra
5 years, 1 month ago (2015-11-17 18:52:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
871e4a2788cb1ddceac741e815c272a9c45c4680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698