components/gcm_driver/crypto/gcm_encryption_provider.cc - Issue 1453503002: [NOT FOR REVIEW] Ensure contributory behaviour for Web Push encryption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/crypto/gcm_encryption_provider.cc

Issue 1453503002: [NOT FOR REVIEW] Ensure contributory behaviour for Web Push encryption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@push-renames

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/crypto/gcm_encryption_provider.cc

diff --git a/components/gcm_driver/crypto/gcm_encryption_provider.cc b/components/gcm_driver/crypto/gcm_encryption_provider.cc

index 5ed56e4fd47d84226c9e8566b5fd2b95fa532366..7bf9900778c0868a637162a401c83a92559dec2c 100644

--- a/components/gcm_driver/crypto/gcm_encryption_provider.cc

+++ b/components/gcm_driver/crypto/gcm_encryption_provider.cc

@@ -177,7 +177,7 @@ void GCMEncryptionProvider::DecryptMessageWithKey(

std::string plaintext;

- GCMMessageCryptographer cryptographer;

+ GCMMessageCryptographer cryptographer(pair.public_key(), dh);

if (!cryptographer.Decrypt(message.raw_data, shared_secret, salt, rs,

&plaintext)) {

DLOG(ERROR) << "Unable to decrypt the incoming data.";

« no previous file with comments | « no previous file | components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc » ('j') | no next file with comments »