xfa/src/fwl/src/theme/checkboxtp.cpp - Issue 1453473002: FWL refcounts never incremented (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/theme/checkboxtp.cpp

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Rebased Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/theme/checkboxtp.cpp

diff --git a/xfa/src/fwl/src/theme/checkboxtp.cpp b/xfa/src/fwl/src/theme/checkboxtp.cpp

index 4e01addc288a4341b86d1c03dd8df19b67b0cb7f..a88fe11ec33bdb9a9eda42472d09ebcc152ceb0c 100644

--- a/xfa/src/fwl/src/theme/checkboxtp.cpp

+++ b/xfa/src/fwl/src/theme/checkboxtp.cpp

@@ -29,11 +29,7 @@ CFWL_CheckBoxTP::~CFWL_CheckBoxTP() {

}

FX_BOOL CFWL_CheckBoxTP::IsValidWidget(IFWL_Widget* pWidget) {

- if (!pWidget)

- return FALSE;

- FX_DWORD dwHash = pWidget->GetClassID();

- return dwHash == FWL_CLASSHASH_CheckBox ||

- dwHash == FWL_CLASSHASH_RadioButton;

+ return pWidget && pWidget->GetClassID() == FWL_CLASSHASH_CheckBox;

}

FX_DWORD CFWL_CheckBoxTP::SetThemeID(IFWL_Widget* pWidget,

FX_DWORD dwThemeID,

« no previous file with comments | « xfa/src/fwl/src/lightwidget/tooltipctrl.cpp ('k') | xfa/src/fxfa/src/app/xfa_fwltheme.cpp » ('j') | no next file with comments »