FWL refcounts never incremented (part 2).

xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp

Index: xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp
diff --git a/xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp b/xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp
index 88b8fbb19bb5137248dd2185e13380b81de89b22..9f5315e36a0719209dcb5d7871feec084f22ffcc 100644
--- a/xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp
+++ b/xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp
@@ -10,26 +10,24 @@
 #include "../core/include/fwl_widgetimp.h"
 #include "include/fwl_editimp.h"
 #include "include/fwl_barcodeimp.h"
-IFWL_Barcode::IFWL_Barcode() {
-}
-FWL_ERR IFWL_Barcode::Initialize(const CFWL_WidgetImpProperties& properties,
-                                 IFWL_Widget* pOuter) {
+
+// static
+IFWL_Barcode* IFWL_Barcode::Create(const CFWL_WidgetImpProperties& properties,
+                                   IFWL_Widget* pOuter) {
+  IFWL_Barcode* pBarcode = new IFWL_Barcode;
   CFWL_BarcodeImp* pBarcodeImpl = new CFWL_BarcodeImp(properties, pOuter);
-  SetImpl(pBarcodeImpl);
-  pBarcodeImpl->SetInterface(this);
-  return pBarcodeImpl->Initialize();

[Tom Sepez, 2015/12/04 19:01:27]

Hint: this ->Initialize() is what the superclass Initialize() now does for us,
so all we need do is move the other logic into create method.

+  pBarcode->SetImpl(pBarcodeImpl);
+  pBarcodeImpl->SetInterface(pBarcode);
+  return pBarcode;
 }
+IFWL_Barcode::IFWL_Barcode() {}
 void IFWL_Barcode::SetType(BC_TYPE type) {
   static_cast<CFWL_BarcodeImp*>(GetImpl())->SetType(type);
 }
 FX_BOOL IFWL_Barcode::IsProtectedType() {
   return static_cast<CFWL_BarcodeImp*>(GetImpl())->IsProtectedType();
 }
-CFWL_BarcodeImp::CFWL_BarcodeImp(IFWL_Widget* pOuter)
-    : CFWL_EditImp(pOuter),
-      m_pBarcodeEngine(NULL),
-      m_dwStatus(0),
-      m_type(BC_UNKNOWN) {}
+
 CFWL_BarcodeImp::CFWL_BarcodeImp(const CFWL_WidgetImpProperties& properties,
                                  IFWL_Widget* pOuter)
     : CFWL_EditImp(properties, pOuter),