FWL refcounts never incremented (part 2).

xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../core/include/fwl_targetimp.h"
 #include "../core/include/fwl_noteimp.h"
 #include "../core/include/fwl_widgetimp.h"
 #include "include/fwl_spinbuttonimp.h"
 #define FWL_SPN_MinWidth 18
 #define FWL_SPN_MinHeight 32
 #define FWL_SPIN_Elapse 200
-IFWL_SpinButton::IFWL_SpinButton() {
+
+// static
+IFWL_SpinButton* IFWL_SpinButton::Create(
+    const CFWL_WidgetImpProperties& properties,
+    IFWL_Widget* pOuter) {
+  IFWL_SpinButton* pSpinButton = new IFWL_SpinButton;
+  CFWL_SpinButtonImp* pSpinButtonImpl =
+      new CFWL_SpinButtonImp(properties, nullptr);
+  pSpinButton->SetImpl(pSpinButtonImpl);
+  pSpinButtonImpl->SetInterface(pSpinButton);
+  return pSpinButton;
 }
-FWL_ERR IFWL_SpinButton::Initialize(const CFWL_WidgetImpProperties& properties,
-                                    IFWL_Widget* pOuter) {
-  CFWL_SpinButtonImp* pSpinButtonImpl = new CFWL_SpinButtonImp(properties);
-  SetImpl(pSpinButtonImpl);
-  pSpinButtonImpl->SetInterface(this);
-  return pSpinButtonImpl->Initialize();
-}
+IFWL_SpinButton::IFWL_SpinButton() {}
 FWL_ERR IFWL_SpinButton::EnableButton(FX_BOOL bEnable, FX_BOOL bUp) {
   return static_cast<CFWL_SpinButtonImp*>(GetImpl())
       ->EnableButton(bEnable, bUp);
 }
 FX_BOOL IFWL_SpinButton::IsButtonEnable(FX_BOOL bUp) {
   return static_cast<CFWL_SpinButtonImp*>(GetImpl())->IsButtonEnable(bUp);
 }
-CFWL_SpinButtonImp::CFWL_SpinButtonImp(IFWL_Widget* pOuter)
-    : CFWL_WidgetImp(pOuter),
-      m_dwUpState(FWL_PARTSTATE_SPB_Normal),
-      m_dwDnState(FWL_PARTSTATE_SPB_Normal),
-      m_iButtonIndex(0),
-      m_bLButtonDwn(FALSE),
-      m_hTimer(NULL) {
-  m_rtClient.Reset();
-  m_rtUpButton.Reset();
-  m_rtDnButton.Reset();
-  m_pProperties->m_dwStyleExes |= FWL_STYLEEXE_SPB_Vert;
-}
+
 CFWL_SpinButtonImp::CFWL_SpinButtonImp(
     const CFWL_WidgetImpProperties& properties,
     IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter),
       m_dwUpState(FWL_PARTSTATE_SPB_Normal),
       m_dwDnState(FWL_PARTSTATE_SPB_Normal),
       m_iButtonIndex(0),
       m_bLButtonDwn(FALSE),
       m_hTimer(NULL) {
   m_rtClient.Reset();
@@ skipping 370 matching lines @@
   if (!bUpEnable && !bDownEnable) {
     return;
   }
   CFWL_EvtSpbClick wmPosChanged;
   wmPosChanged.m_pSrcTarget = m_pOwner->m_pInterface;
   wmPosChanged.m_bUp = bUpEnable;
   m_pOwner->DispatchEvent(&wmPosChanged);
   m_pOwner->Repaint(bUpEnable ? &m_pOwner->m_rtUpButton
                               : &m_pOwner->m_rtDnButton);
 }