FWL refcounts never incremented (part 2).

xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../core/include/fwl_targetimp.h"
 #include "../core/include/fwl_noteimp.h"
 #include "../core/include/fwl_widgetimp.h"
 #include "../core/include/fwl_widgetmgrimp.h"
 #include "include/fwl_checkboximp.h"
 #define FWL_CKB_CaptionMargin 5
-IFWL_CheckBox::IFWL_CheckBox() {
+
+// static
+IFWL_CheckBox* IFWL_CheckBox::Create(const CFWL_WidgetImpProperties& properties,
+                                     IFWL_Widget* pOuter) {
+  IFWL_CheckBox* pCheckBox = new IFWL_CheckBox;
+  CFWL_CheckBoxImp* pCheckBoxImpl = new CFWL_CheckBoxImp(properties, pOuter);
+  pCheckBox->SetImpl(pCheckBoxImpl);
+  pCheckBoxImpl->SetInterface(pCheckBox);
+  return pCheckBox;
 }
-FWL_ERR IFWL_CheckBox::Initialize(const CFWL_WidgetImpProperties& properties,
-                                  IFWL_Widget* pOuter) {
-  CFWL_CheckBoxImp* pCheckBoxImpl = new CFWL_CheckBoxImp(properties, pOuter);
-  SetImpl(pCheckBoxImpl);
-  pCheckBoxImpl->SetInterface(this);
-  return pCheckBoxImpl->Initialize();
-}
+IFWL_CheckBox::IFWL_CheckBox() {}
 int32_t IFWL_CheckBox::GetCheckState() {
   return static_cast<CFWL_CheckBoxImp*>(GetImpl())->GetCheckState();
 }
 FWL_ERR IFWL_CheckBox::SetCheckState(int32_t iCheck) {
   return static_cast<CFWL_CheckBoxImp*>(GetImpl())->SetCheckState(iCheck);
 }
-IFWL_RadioButton::IFWL_RadioButton() {
-}
-FWL_ERR IFWL_RadioButton::Initialize(const CFWL_WidgetImpProperties& properties,
-                                     IFWL_Widget* pOuter) {
-  CFWL_CheckBoxImp* pCheckBoxImpl = new CFWL_CheckBoxImp(properties, pOuter);
-  SetImpl(pCheckBoxImpl);
-  pCheckBoxImpl->SetInterface(this);
-  return pCheckBoxImpl->Initialize();
-}
-CFWL_CheckBoxImp::CFWL_CheckBoxImp(IFWL_Widget* pOuter)
-    : CFWL_WidgetImp(pOuter),
-      m_dwTTOStyles(FDE_TTOSTYLE_SingleLine),
-      m_iTTOAlign(FDE_TTOALIGNMENT_Center),
-      m_bBtnDown(FALSE) {
-  m_rtClient.Reset();
-  m_rtBox.Reset();
-  m_rtCaption.Reset();
-  m_rtFocus.Reset();
-}
+
 CFWL_CheckBoxImp::CFWL_CheckBoxImp(const CFWL_WidgetImpProperties& properties,
                                    IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter),
       m_dwTTOStyles(FDE_TTOSTYLE_SingleLine),
       m_iTTOAlign(FDE_TTOALIGNMENT_Center),
       m_bBtnDown(FALSE) {
   m_rtClient.Reset();
   m_rtBox.Reset();
   m_rtCaption.Reset();
   m_rtFocus.Reset();
 }
 CFWL_CheckBoxImp::~CFWL_CheckBoxImp() {}
 FWL_ERR CFWL_CheckBoxImp::GetClassName(CFX_WideString& wsClass) const {
-  wsClass = (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CKB_RadioButton)
-                ? FWL_CLASS_RadioButton
-                : FWL_CLASS_CheckBox;
+  wsClass = FWL_CLASS_CheckBox;
   return FWL_ERR_Succeeded;
 }
 FX_DWORD CFWL_CheckBoxImp::GetClassID() const {
-  return m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CKB_RadioButton
-             ? FWL_CLASSHASH_RadioButton
-             : FWL_CLASSHASH_CheckBox;
+  return FWL_CLASSHASH_CheckBox;
 }
 FWL_ERR CFWL_CheckBoxImp::Initialize() {
   if (CFWL_WidgetImp::Initialize() != FWL_ERR_Succeeded)
     return FWL_ERR_Indefinite;
   m_pDelegate = new CFWL_CheckBoxImpDelegate(this);
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_CheckBoxImp::Finalize() {
   delete m_pDelegate;
   m_pDelegate = nullptr;
@@ skipping 480 matching lines @@
 void CFWL_CheckBoxImpDelegate::OnKeyDown(CFWL_MsgKey* pMsg) {
   if (pMsg->m_dwKeyCode == FWL_VKEY_Tab) {
     m_pOwner->DispatchKeyEvent(pMsg);
     return;
   }
   if (pMsg->m_dwKeyCode == FWL_VKEY_Return ||
       pMsg->m_dwKeyCode == FWL_VKEY_Space) {
     m_pOwner->NextStates();
   }
 }