FWL refcounts never incremented (part 2).

xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../core/include/fwl_targetimp.h"
 #include "../core/include/fwl_noteimp.h"
 #include "../core/include/fwl_widgetimp.h"
 #include "include/fwl_caretimp.h"
-IFWL_Caret::IFWL_Caret() {
+
+// static
+IFWL_Caret* IFWL_Caret::Create(const CFWL_WidgetImpProperties& properties,
+                               IFWL_Widget* pOuter) {
+  IFWL_Caret* pCaret = new IFWL_Caret;
+  CFWL_CaretImp* pCaretImpl = new CFWL_CaretImp(properties, pOuter);
+  pCaret->SetImpl(pCaretImpl);
+  pCaretImpl->SetInterface(pCaret);
+  return pCaret;
 }
-FWL_ERR IFWL_Caret::Initialize(IFWL_Widget* pOuter) {
-  CFWL_CaretImp* pCaretImpl = new CFWL_CaretImp(pOuter);
-  SetImpl(pCaretImpl);
-  pCaretImpl->SetInterface(this);
-  return pCaretImpl->Initialize();
-}
-FWL_ERR IFWL_Caret::Initialize(const CFWL_WidgetImpProperties& properties,
-                               IFWL_Widget* pOuter) {
-  CFWL_CaretImp* pCaretImpl = new CFWL_CaretImp(properties, pOuter);
-  SetImpl(pCaretImpl);
-  pCaretImpl->SetInterface(this);
-  return pCaretImpl->Initialize();
-}
+IFWL_Caret::IFWL_Caret() {}
 FWL_ERR IFWL_Caret::ShowCaret(FX_BOOL bFlag) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->ShowCaret(bFlag);
 }
 FWL_ERR IFWL_Caret::GetFrequency(FX_DWORD& elapse) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->GetFrequency(elapse);
 }
 FWL_ERR IFWL_Caret::SetFrequency(FX_DWORD elapse) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->SetFrequency(elapse);
 }
 FWL_ERR IFWL_Caret::SetColor(CFX_Color crFill) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->SetColor(crFill);
 }
-CFWL_CaretImp::CFWL_CaretImp(IFWL_Widget* pOuter) : m_hTimer(NULL) {
-  m_dwElapse = 400;
-  m_pTimer = new CFWL_CaretTimer(this);
-  m_bSetColor = FALSE;
-  SetStates(FWL_STATE_CAT_HightLight);
-}
+
 CFWL_CaretImp::CFWL_CaretImp(const CFWL_WidgetImpProperties& properties,
                              IFWL_Widget* pOuter)
-    : m_hTimer(NULL) {
-  m_dwElapse = 400;
+    : CFWL_WidgetImp(properties, pOuter),
+      m_hTimer(nullptr),
+      m_dwElapse(400),
+      m_bSetColor(FALSE) {
   m_pTimer = new CFWL_CaretTimer(this);
-  m_bSetColor = FALSE;
   SetStates(FWL_STATE_CAT_HightLight);
 }
 CFWL_CaretImp::~CFWL_CaretImp() {
   if (m_pTimer) {
     delete m_pTimer;
     m_pTimer = NULL;
   }
 }
 FWL_ERR CFWL_CaretImp::GetClassName(CFX_WideString& wsClass) const {
   wsClass = FWL_CLASS_Caret;
@@ skipping 92 matching lines @@
 }
 CFWL_CaretImpDelegate::CFWL_CaretImpDelegate(CFWL_CaretImp* pOwner)
     : m_pOwner(pOwner) {}
 int32_t CFWL_CaretImpDelegate::OnProcessMessage(CFWL_Message* pMessage) {
   return 1;
 }
 FWL_ERR CFWL_CaretImpDelegate::OnDrawWidget(CFX_Graphics* pGraphics,
                                             const CFX_Matrix* pMatrix) {
   return m_pOwner->DrawWidget(pGraphics, pMatrix);
 }