FWL refcounts never incremented (part 2).

xfa/include/fwl/core/fwl_target.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FWL_TARGET_H_
 #define FWL_TARGET_H_
 
 #include "core/include/fxcrt/fx_basic.h"
@@ skipping 13 matching lines @@
 //      CFWL_...                IFWL_...                CFWL_...Imp
 //
 
 class CFWL_TargetImp;
 
 class IFWL_Target {
  public:
   IFWL_Target() : m_pImpl(nullptr) {}
   virtual ~IFWL_Target();
 
+  // These call into equivalent polymorphic methods of m_pImpl. There
+  // should be no need to override these in subclasses.
   FWL_ERR GetClassName(CFX_WideString& wsClass) const;
   FX_DWORD GetClassID() const;
   FX_BOOL IsInstance(const CFX_WideStringC& wsClass) const;
   FWL_ERR Initialize();

[Tom Sepez, 2015/12/04 19:01:27]

Hint: this is what allows me to remove many Initialize methods.

   FWL_ERR Finalize();
 
   CFWL_TargetImp* GetImpl() const { return m_pImpl; }
+
+ protected:
   void SetImpl(CFWL_TargetImp* pImpl) { m_pImpl = pImpl; }
 
  private:
   CFWL_TargetImp* m_pImpl;
 };
 
 #endif  // FWL_TARGET_H_