Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453373006: Kill dead IFWL_*::Initialize() variants dead. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Kill dead IFWL_*::Initialize() variants dead. Remove default argument in remaining variants. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/44971898e73ce68f0014ff588e5556c20332cdd0

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -176 lines) Patch
M xfa/include/fwl/basewidget/fwl_barcode.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_caret.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_checkbox.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_combobox.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_datetimepicker.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_edit.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_listbox.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_monthcalendar.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_picturebox.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_pushbutton.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_scrollbar.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_tooltipctrl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/include/fwl/core/fwl_content.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_form.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/include/fwl/core/fwl_grid.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_panel.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M xfa/include/fwl/core/fwl_widget.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_gridimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_panelimp.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/barcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/combobox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/picturebox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, dead code.
5 years, 1 month ago (2015-11-19 00:10:39 UTC) #3
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-19 00:34:23 UTC) #4
Tom Sepez
5 years, 1 month ago (2015-11-19 01:08:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
44971898e73ce68f0014ff588e5556c20332cdd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698