third_party/libpng/README.google - Issue 1453373003: Update the version of libpng used by Skia tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libpng/README.google

Issue 1453373003: Update the version of libpng used by Skia tests (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« DEPS ('K') | « third_party/libpng/LICENSE ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »

OLD	NEW
1 URL: http://www.libpng.org/pub/png/libpng.html	1 URL: http://www.libpng.org/pub/png/libpng.html

2 Version: 1.6.16	2 Version: 1.6.16

3 License: libpng license	3 License: libpng license

4 License File: LICENSE, pulled out of png.h	4 License File: LICENSE, pulled out of png.h

5 Description: png compression/decompression library	5 Description: png compression/decompression library

6 Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a	6 Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a

7 rename with a few additional settings enabled). (2) Pulled LICENSE into	7 rename with a few additional settings enabled). (2) Copied LICENSE into

8 its own file.	8 this directory. (Originally it was pulled from png.h, but libpng has

	9 now provided a separate LICENSE file for convenience, which we use

	10 directly.)

9	11

10 FAQ:	12 FAQ:

11 Q: Why does this directory exist?	13 Q: Why does this directory exist?

12 A: libpng is pulled in through DEPS, but in order to build it using ninja, we	14 A: libpng is pulled in through DEPS, but in order to build it using ninja, we

13 need to create pnglibconf.h. We originally tried creating	15 need to create pnglibconf.h. We originally tried creating

14 the file as an action in https://codereview.chromium.org/930283002/, but this	16 the file as an action in https://codereview.chromium.org/930283002/, but this

15 apparently led to a race condition on Windows, where some builds failed to	17 apparently led to a race condition on Windows, where some builds failed to

16 create the file in time for other files to include it. By checking these	18 create the file in time for other files to include it. By checking these

17 files directly into Skia, we eliminate the race condition.	19 files directly into Skia, we eliminate the race condition.

OLD	NEW