Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 1453373003: Update the version of libpng used by Skia tests (Closed)

Created:
5 years, 1 month ago by scroggo_chromium
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update the version of libpng used by Skia tests The version of libpng we were using has some security vulnerabilities. Update to a newer version - 1.6.20 (http://sourceforge.net/p/libpng/code/ci/047737496a77eeb97f9991919dac08ca3c149711/). Update pnglibconf.h. The new version is a copy of the newer version of the file, with our /* custom settings */ tacked onto the end. (The custom settings are unchanged from the last version.) Update the LICENSE. The new version is a copy of the LICENSE that libpng now includes as a separate file. Update the README file to reflect the change in source of the LICENSE file. BUG=skia:4573 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1453373003 Committed: https://skia.googlesource.com/skia/+/77b798ce8e8616e8cb0e82a22ad9eb4f69eb271f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : 1.6.20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -183 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/LICENSE View 1 chunk +112 lines, -172 lines 0 comments Download
M third_party/libpng/README.google View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/libpng/pnglibconf.h View 1 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
scroggo
not lgtm This should work once skia.googlesource gets updated (tested locally by pulling in the ...
5 years, 1 month ago (2015-11-18 16:04:49 UTC) #2
scroggo
On 2015/11/18 16:04:49, scroggo wrote: > not lgtm > > This should work once skia.googlesource ...
4 years, 10 months ago (2016-02-19 02:11:05 UTC) #4
scroggo
4 years, 10 months ago (2016-02-19 02:11:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453373003/20001
4 years, 10 months ago (2016-02-19 02:13:05 UTC) #8
msarett
lgtm I may try to make another quick update if I am able to upstream ...
4 years, 10 months ago (2016-02-19 13:41:28 UTC) #10
msarett
Actually, the optimizations have just been merged into upstream... This is fine to land, but ...
4 years, 10 months ago (2016-02-19 13:43:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453373003/40001
4 years, 10 months ago (2016-02-19 13:57:25 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 14:33:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/77b798ce8e8616e8cb0e82a22ad9eb4f69eb271f

Powered by Google App Engine
This is Rietveld 408576698