Issue 1453353002: - Do not include the sources as part of the generated files on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1453353002: - Do not include the sources as part of the generated files on (Closed)

Created:
5 years, 1 month ago by Ivan Posva

Modified:
5 years, 1 month ago

Reviewers:
Chinmay, siva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Do not include the sources as part of the generated files on Windows to avoid creating string literals that are too large. BUG= Committed: https://github.com/dart-lang/sdk/commit/f28afad3537b1b66ac8cda4a01ecfdd542df66c8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	runtime/tools/gen_library_src_paths.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Ivan Posva

5 years, 1 month ago (2015-11-18 00:11:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f28afad3537b1b66ac8cda4a01ecfdd542df66c8 (presubmit successful).