Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1453343003: Fix multiple return statements in typing-asm, cleanup. (Closed)

Created:
5 years, 1 month ago by bradn
Modified:
5 years, 1 month ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix multiple return statements in typing-asm, cleanup. The last change to typing-asm broke non-final return statements. Fixing this. Finishing out a partially completed test that landed by mistake. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/0acb70baaf95e2497464d22b306a148d49fdfaa6 Cr-Commit-Position: refs/heads/master@{#32096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -14 lines) Patch
M src/typing-asm.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 2 chunks +57 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bradn
5 years, 1 month ago (2015-11-18 00:07:31 UTC) #1
titzer
On 2015/11/18 00:07:31, bradn wrote: lgtm
5 years, 1 month ago (2015-11-18 08:41:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453343003/1
5 years, 1 month ago (2015-11-18 19:46:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 19:47:24 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:48:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0acb70baaf95e2497464d22b306a148d49fdfaa6
Cr-Commit-Position: refs/heads/master@{#32096}

Powered by Google App Engine
This is Rietveld 408576698