Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453303003: X87: Experimental support for RegExp lookbehind. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Experimental support for RegExp lookbehind. port 906903acb558723edf5bf87581c0c37183dc6c46 (r32043) original commit message: BUG= Committed: https://crrev.com/9f594402c336df22a696d602a02833136e6eea15 Cr-Commit-Position: refs/heads/master@{#32069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -53 lines) Patch
M src/regexp/x87/regexp-macro-assembler-x87.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 16 chunks +83 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-18 03:29:01 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-18 04:15:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453303003/1
5 years, 1 month ago (2015-11-18 04:15:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 04:42:47 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 04:43:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f594402c336df22a696d602a02833136e6eea15
Cr-Commit-Position: refs/heads/master@{#32069}

Powered by Google App Engine
This is Rietveld 408576698