Drag and drop between app list and launcher - First patch

ash/wm/app_list_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_APP_LIST_CONTROLLER_H_
 #define ASH_WM_APP_LIST_CONTROLLER_H_
 
 #include "ash/launcher/launcher_icon_observer.h"
 #include "ash/shell_observer.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/timer.h"
 #include "ui/app_list/pagination_model_observer.h"
 #include "ui/aura/client/focus_change_observer.h"
 #include "ui/aura/root_window_observer.h"
 #include "ui/base/events/event_handler.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/gfx/rect.h"
 #include "ui/views/widget/widget_observer.h"
 
 namespace app_list {
+class ApplicationDragAndDropHost;
 class AppListView;
 class PaginationModel;
 }
 
 namespace ui {
 class LocatedEvent;
 }
 
 namespace ash {
 namespace internal {
@@ skipping 22 matching lines @@
   // Whether app list window is visible (shown or being shown).
   bool IsVisible() const;
 
   // Returns target visibility. This differs from IsVisible() if an animation
   // is ongoing.
   bool GetTargetVisibility() const { return is_visible_; }
 
   // Returns app list window or NULL if it is not visible.
   aura::Window* GetWindow();
 
+  // If |drag_and_drop_host| is not NULL it will be called upon drag and drop
+  // operations outside the application list.
+  void SetDragAndDropHostOfCurrentAppList(

[koz (OOO until 15th September), 2013/05/08 02:00:39]

Could you rename this to SetDragAndDropHost()? I think the "OfCurrentAppList"
bit is implied, eg: SetVisible() is implicitly talking about the current app
list.

[Mr4D (OOO till 08-26), 2013/05/08 02:53:35]

I did this because of my previous reviewer asked me to. His reasoning is that it
is clear that the association has to be set to the current object (every time)
since the object might go away AND the object needs first to be created before
it can be set.

+      app_list::ApplicationDragAndDropHost* drag_and_drop_host);
+
  private:
   // Sets the app list view and attempts to show it.
   void SetView(app_list::AppListView* view);
 
   // Forgets the view.
   void ResetView();
 
   // Starts show/hide animation.
   void ScheduleAnimation();
 
@@ skipping 45 matching lines @@
   // Whether should schedule snap back animation.
   bool should_snap_back_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListController);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_WM_APP_LIST_CONTROLLER_H_