Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 14533004: Start menu shortcuts for apps on Windows are now inside a "Chrome Apps" submenu. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Minor nit. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index 53449e63ff8d2074601ce2a095285f5e39216e0c..7a07e8039be6bb35d3efe5abb477c1432e5fda9b 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -27,6 +27,7 @@
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "googleurl/src/gurl.h"
+#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
#include "grit/theme_resources.h"
@@ -377,6 +378,7 @@ bool CreateApplicationShortcutView::Accept() {
creation_locations.on_desktop = desktop_check_box_->checked();
creation_locations.in_applications_menu = menu_check_box_ == NULL ? false :
menu_check_box_->checked();
+ creation_locations.applications_menu_subdir = shortcut_menu_subdir_;
#if defined(OS_WIN)
creation_locations.in_quick_launch_bar = quick_launch_check_box_ == NULL ?
@@ -431,6 +433,9 @@ CreateUrlApplicationShortcutView::CreateUrlApplicationShortcutView(
FetchIcon();
}
+ // NOTE: Leave shortcut_menu_subdir_ blank to create URL app shortcuts in the
+ // top-level menu.
+
InitControls();
}
@@ -510,6 +515,10 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView(
shortcut_info_.title = UTF8ToUTF16(app->name());
shortcut_info_.description = UTF8ToUTF16(app->description());
+ // Place Chrome app shortcuts in the "Chrome Apps" submenu.
+ shortcut_menu_subdir_ =
+ l10n_util::GetStringUTF16(IDS_APP_SHORTCUTS_SUBDIR_NAME);
+
InitControls();
// Get shortcut information and icon now; they are needed for our UI.
« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.h ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698