Improve input handling for WaveAudioHandler.

media/audio/simple_sources_unittest.cc

Index: media/audio/simple_sources_unittest.cc
diff --git a/media/audio/simple_sources_unittest.cc b/media/audio/simple_sources_unittest.cc
index 51cb740f56ef1b794bb3b414e133df2bb61e7e61..ad04f359d224f4cf35dae1acb7dae57d91f66c81 100644
--- a/media/audio/simple_sources_unittest.cc
+++ b/media/audio/simple_sources_unittest.cc
@@ -4,11 +4,13 @@
 
 #include <limits>
 
+#include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "media/audio/audio_parameters.h"
 #include "media/audio/simple_sources.h"
+#include "media/audio/sounds/test_data.h"
 #include "media/base/audio_bus.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -75,4 +77,106 @@ TEST(SimpleSources, OnError) {
   EXPECT_EQ(2, source.errors());
 }
 
+TEST(SimpleSources, FileSourceTestData) {
+  const int kNumFrames = 10;
+
+  // Create a temporary file filled with WAV data.
+  base::FilePath temp_path;
+  ASSERT_TRUE(base::CreateTemporaryFile(&temp_path));
+  base::File temp(temp_path,
+                  base::File::FLAG_WRITE | base::File::FLAG_OPEN_ALWAYS);
+  temp.WriteAtCurrentPos(kTestAudioData, arraysize(kTestAudioData) - 1);
+  ASSERT_EQ(arraysize(kTestAudioData) - 1, (size_t)temp.GetLength());

[tommi (sloooow) - chröme, 2015/11/20 09:45:23]

static_cast

[slan, 2015/11/20 18:09:36]

Done, here and below.

+  temp.Close();
+
+  // Create AudioParameters which match those in the WAV data.
+  AudioParameters params(AudioParameters::AUDIO_PCM_LINEAR,
+                         CHANNEL_LAYOUT_STEREO,
+                         48000,
+                         16,
+                         kNumFrames);
+  scoped_ptr<AudioBus> audio_bus = AudioBus::Create(2, kNumFrames);
+  audio_bus->Zero();
+
+  // Create a FileSource that reads this file.
+  FileSource source(params, temp_path);
+  EXPECT_EQ(kNumFrames, source.OnMoreData(audio_bus.get(), 0));
+
+  // Convert the test data (little-endian) into floats and compare.
+  const int kFirstSampleIndex = 12 + 8 + 16 + 8;
+  int16_t data[2];
+  data[0] = kTestAudioData[kFirstSampleIndex];
+  data[0] |= (kTestAudioData[kFirstSampleIndex + 1] << 8);
+  data[1] = kTestAudioData[kFirstSampleIndex + 2];
+  data[1] |= (kTestAudioData[kFirstSampleIndex + 3] << 8);
+
+  // The first frame should hold the WAV data.
+  EXPECT_FLOAT_EQ(static_cast<float>(data[0]) / ((1 << 15) - 1),
+                  audio_bus->channel(0)[0]);
+  EXPECT_FLOAT_EQ(static_cast<float>(data[1]) / ((1 << 15) - 1),
+                  audio_bus->channel(1)[0]);
+
+  // All other frames should be zero-padded.
+  for (int channel = 0; channel < audio_bus->channels(); ++channel) {
+    for (int frame = 1; frame < audio_bus->frames(); ++frame) {
+      EXPECT_FLOAT_EQ(0.0, audio_bus->channel(channel)[frame]);
+    }
+  }
+}
+
+TEST(SimpleSources, BadFilePathFails) {
+  AudioParameters params(
+      AudioParameters::AUDIO_PCM_LINEAR, CHANNEL_LAYOUT_STEREO, 48000, 16, 10);
+  scoped_ptr<AudioBus> audio_bus = AudioBus::Create(2, 10);
+  audio_bus->Zero();
+
+  // Create a FileSource that reads this file.
+  FileSource source(params, base::FilePath("/does/not/exist"));
+  EXPECT_EQ(0, source.OnMoreData(audio_bus.get(), 0));
+
+  // Confirm all frames are zero-padded.
+  for (int channel = 0; channel < audio_bus->channels(); ++channel) {
+    for (int frame = 0; frame < audio_bus->frames(); ++frame) {
+      EXPECT_FLOAT_EQ(0.0, audio_bus->channel(channel)[frame]);
+    }
+  }
+}
+
+TEST(SimpleSources, FileSourceCorruptTestDataFails) {
+  const int kNumFrames = 10;
+
+  // Create a temporary file filled with WAV data.
+  base::FilePath temp_path;
+  ASSERT_TRUE(base::CreateTemporaryFile(&temp_path));
+  base::File temp(temp_path,
+                  base::File::FLAG_WRITE | base::File::FLAG_OPEN_ALWAYS);
+  temp.WriteAtCurrentPos(kTestAudioData, arraysize(kTestAudioData) - 1);
+
+  // Corrupt the header.
+  temp.Write(3, "0x00", 1);
+
+  ASSERT_EQ(arraysize(kTestAudioData) - 1, (size_t)temp.GetLength());
+  temp.Close();
+
+  // Create AudioParameters which match those in the WAV data.
+  AudioParameters params(AudioParameters::AUDIO_PCM_LINEAR,
+                         CHANNEL_LAYOUT_STEREO,
+                         48000,
+                         16,
+                         kNumFrames);
+  scoped_ptr<AudioBus> audio_bus = AudioBus::Create(2, kNumFrames);
+  audio_bus->Zero();
+
+  // Create a FileSource that reads this file.
+  FileSource source(params, temp_path);
+  EXPECT_EQ(0, source.OnMoreData(audio_bus.get(), 0));
+
+  // Confirm all frames are zero-padded.
+  for (int channel = 0; channel < audio_bus->channels(); ++channel) {
+    for (int frame = 0; frame < audio_bus->frames(); ++frame) {
+      EXPECT_FLOAT_EQ(0.0, audio_bus->channel(channel)[frame]);
+    }
+  }
+}
+
 }  // namespace media