Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: media/audio/sounds/audio_stream_handler.h

Issue 1453233002: Improve input handling for WaveAudioHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Remove VLOG()s Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_ 5 #ifndef MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_
6 #define MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_ 6 #define MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // and won't be changed during playback. Returns true iff new playback 46 // and won't be changed during playback. Returns true iff new playback
47 // was successfully started. 47 // was successfully started.
48 // 48 //
49 // NOTE: if current playback isn't at end of stream, playback request 49 // NOTE: if current playback isn't at end of stream, playback request
50 // is dropped, but true is returned. 50 // is dropped, but true is returned.
51 bool Play(); 51 bool Play();
52 52
53 // Stops current playback. 53 // Stops current playback.
54 void Stop(); 54 void Stop();
55 55
56 const WavAudioHandler& wav_audio_handler() const { return wav_audio_; } 56 // If AudioStreamHandler is not initialized, this will return nullptr.
57 const WavAudioHandler* wav_audio_handler() const { return wav_audio_.get(); }
57 58
58 private: 59 private:
59 friend class AudioStreamHandlerTest; 60 friend class AudioStreamHandlerTest;
60 friend class SoundsManagerTest; 61 friend class SoundsManagerTest;
61 62
62 class AudioStreamContainer; 63 class AudioStreamContainer;
63 64
64 static void SetObserverForTesting(TestObserver* observer); 65 static void SetObserverForTesting(TestObserver* observer);
65 static void SetAudioSourceForTesting( 66 static void SetAudioSourceForTesting(
66 AudioOutputStream::AudioSourceCallback* source); 67 AudioOutputStream::AudioSourceCallback* source);
67 68
68 WavAudioHandler wav_audio_; 69 scoped_ptr<WavAudioHandler> wav_audio_;
69 scoped_ptr<AudioStreamContainer> stream_; 70 scoped_ptr<AudioStreamContainer> stream_;
70 71
71 bool initialized_; 72 bool initialized_;
72 73
73 DISALLOW_COPY_AND_ASSIGN(AudioStreamHandler); 74 DISALLOW_COPY_AND_ASSIGN(AudioStreamHandler);
74 }; 75 };
75 76
76 } // namespace media 77 } // namespace media
77 78
78 #endif // MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_ 79 #endif // MEDIA_AUDIO_SOUNDS_AUDIO_STREAM_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698