Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 14532005: Check for cyclicity in named mixin applications. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/mixin_cyclic_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 8043517e444cc077f232165c333282291f8fe848..465749d60b934309eda623481fe6eaeb5f195153 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -3513,8 +3513,10 @@ class ClassSupertypeResolver extends CommonResolverVisitor {
}
void visitNodeList(NodeList node) {
- for (Link<Node> link = node.nodes; !link.isEmpty; link = link.tail) {
- link.head.accept(this);
+ if (node != null) {
+ for (Link<Node> link = node.nodes; !link.isEmpty; link = link.tail) {
+ link.head.accept(this);
+ }
}
}
@@ -3534,6 +3536,12 @@ class ClassSupertypeResolver extends CommonResolverVisitor {
visitNodeList(node.mixins);
}
+ void visitNamedMixinApplication(NamedMixinApplication node) {
+ node.superclass.accept(this);
+ visitNodeList(node.mixins);
+ visitNodeList(node.interfaces);
+ }
+
void visitTypeAnnotation(TypeAnnotation node) {
node.typeName.accept(this);
}
« no previous file with comments | « no previous file | tests/language/mixin_cyclic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698